[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. IMPALA-5801: Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 12: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Laszlo Gaal, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#11). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-20 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: Code-Review+2 (2 comments) This seems like an improv

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9063/

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/90

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/9063/

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Laszlo Gaal, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#9). Change subject: IMPALA-5801: Clean up codegen GetType() interface ...

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-19 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/9063/

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 8: I took the liberty to make the GetIntConstant clean

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-16 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#8). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 7: I have uploaded a patch with the template approach.

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-14 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#7). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-14 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#6). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 5: Code-Review+2 This looks good to me. I'm ok if you wa

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 5: Yeah maybe the template approach makes sense then, so

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: Clean up codegen GetType() interface .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#5). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#4). Change subject: IMPALA-5801: Clean up codegen GetType() interface ..