[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. IMPALA-8690 (prep 3): Factor out

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 10: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 10: Code-Review+2 Rebased,

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 7: (1 comment) Rebased

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15179 to look at the new patch set (#10). Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 9: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 9: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-24 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15179 to look at the new patch set (#8). Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 7: (12 comments)

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 7: (6 comments) mostly nits,

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. IMPALA-8690 (prep 3): Factor out common code

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15179 to look at the new patch set (#4). Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. IMPALA-8690 (prep 3): Factor out common code

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15179 ) Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8690 (prep 3): Factor out common code for cache implementations

2020-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15179 Change subject: IMPALA-8690 (prep 3): Factor out common code for cache implementations .. IMPALA-8690 (prep 3): Factor out common code