[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. IMPALA-8889: Fix error messages for unsupported operations on acid tables Provides up-to-date error messages for acid tables. Makes minor code change for ensureTableWriteSupported after HIVEMANAGEDINSERTWRITE is enabled. Tests: Fixed and tested AnalyerTest Fixed acid-negative test Ran all core tests for Hive 3 Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Reviewed-on: http://gerrit.cloudera.org:8080/14133 Tested-by: Impala Public Jenkins Reviewed-by: Zoltan Borok-Nagy --- M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/workloads/functional-query/queries/QueryTest/acid-negative.test 7 files changed, 19 insertions(+), 25 deletions(-) Approvals: Impala Public Jenkins: Verified Zoltan Borok-Nagy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 5 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Tue, 27 Aug 2019 11:57:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 20:40:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4368/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 17:03:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4845/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 16:35:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 3: (1 comment) patch 3 add the space. http://gerrit.cloudera.org:8080/#/c/14133/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/14133/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@242 PS2, Line 242: operationStr, table.getFullName())); > nit: missing space Done -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 16:24:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14133 to look at the new patch set (#3). Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. IMPALA-8889: Fix error messages for unsupported operations on acid tables Provides up-to-date error messages for acid tables. Makes minor code change for ensureTableWriteSupported after HIVEMANAGEDINSERTWRITE is enabled. Tests: Fixed and tested AnalyerTest Fixed acid-negative test Ran all core tests for Hive 3 Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe --- M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/workloads/functional-query/queries/QueryTest/acid-negative.test 7 files changed, 19 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/14133/3 -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 3 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14133/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/14133/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@242 PS2, Line 242: operationStr,table.getFullName())); nit: missing space -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 16:07:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 2: (2 comments) Submit patch set 2 to fix the commit message. http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@9 PS1, Line 9: up-to-da > typo? Done http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@10 PS1, Line 10: Makes minor code change for ensureTableWriteSupported after > I do not understand what this means. Can you add more detail? This is talking about https://gerrit.cloudera.org/c/14133/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#294 I will add more information. -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 14:50:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14133 to look at the new patch set (#2). Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. IMPALA-8889: Fix error messages for unsupported operations on acid tables Provides up-to-date error messages for acid tables. Makes minor code change for ensureTableWriteSupported after HIVEMANAGEDINSERTWRITE is enabled. Tests: Fixed and tested AnalyerTest Fixed acid-negative test Ran all core tests for Hive 3 Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe --- M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/workloads/functional-query/queries/QueryTest/acid-negative.test 7 files changed, 19 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/14133/2 -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 2 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 1: Code-Review+2 (2 comments) The code looks good to me, but I do not understand some parts of the commit message. http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@9 PS1, Line 9: uptodate typo? http://gerrit.cloudera.org:8080/#/c/14133/1//COMMIT_MSG@10 PS1, Line 10: Makes minor code change after HIVEMANAGEDINSERTWRITE is enabled. I do not understand what this means. Can you add more detail? -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 26 Aug 2019 13:22:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4360/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 24 Aug 2019 06:47:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14133 Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. IMPALA-8889: Fix error messages for unsupported operations on acid tables Provides uptodate error messages for acid tables. Makes minor code change after HIVEMANAGEDINSERTWRITE is enabled. Tests: Fixed and tested AnalyerTest Fixed acid-negative test Ran all core tests for Hive 3 Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe --- M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/workloads/functional-query/queries/QueryTest/acid-negative.test 7 files changed, 19 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/14133/1 -- To view, visit http://gerrit.cloudera.org:8080/14133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I732bf651405c9ed75d1843390050b786720e3ffe Gerrit-Change-Number: 14133 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen
