[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0
Thomas Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/12793 ) Change subject: Fix error when PUBLISH_DEPENDENCIES=0 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ief2d6d9daf1b06091f3773b5abae0aebe0a3d15a Gerrit-Change-Number: 12793 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta
[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0
Hector Acosta has posted comments on this change. (
http://gerrit.cloudera.org:8080/12793 )
Change subject: Fix error when PUBLISH_DEPENDENCIES=0
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12793/1/functions.sh
File functions.sh:
http://gerrit.cloudera.org:8080/#/c/12793/1/functions.sh@391
PS1, Line 391: if [[ "PUBLISH_DEPENDENCIES" -eq "1" ]]; then
: : ${PUBLISH_DEPENDENCIES_S3=1}
: : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=1}
: else
: : ${PUBLISH_DEPENDENCIES_S3=0}
: : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=0}
: fi
I'm about to basically submit the same thing. I think this is equivalent to:
: ${PUBLISH_DEPENDENCIES_S3=${PUBLISH_DEPENDENCIES}}
--
To view, visit http://gerrit.cloudera.org:8080/12793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief2d6d9daf1b06091f3773b5abae0aebe0a3d15a
Gerrit-Change-Number: 12793
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall
Gerrit-Reviewer: Hector Acosta
Gerrit-Comment-Date: Tue, 19 Mar 2019 23:33:20 +
Gerrit-HasComments: Yes
[native-toolchain-CR] Fix error when PUBLISH DEPENDENCIES=0
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12793 Change subject: Fix error when PUBLISH_DEPENDENCIES=0 .. Fix error when PUBLISH_DEPENDENCIES=0 Running the build with PUBLISH_DEPENDENCIES=0 can result in the error 'PUBLISH_DEPENDENCIES_ARTIFACTORY: unbound variable'. This patch fixes it by setting this PUBLISH_DEPENDENCIES_ARTIFACTORY and PUBLISH_DEPENDENCIES_S3 to 0 when PUBLISH_DEPENDENCIES=0 Change-Id: Ief2d6d9daf1b06091f3773b5abae0aebe0a3d15a --- M functions.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/93/12793/1 -- To view, visit http://gerrit.cloudera.org:8080/12793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ief2d6d9daf1b06091f3773b5abae0aebe0a3d15a Gerrit-Change-Number: 12793 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall
