[Impala-ASF-CR] IMPALA-4136: testKudu planner test hangs if Kudu is not supported

2016-09-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4136: testKudu planner test hangs if Kudu is not supported .. Patch Set 1: Code-Review+2 Thanks, Matt! -- To view, visit

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4353 To

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4411 To

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4421 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 17: (10 comments) These are the comments from re-reviewing the addressed comments. Will

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4428 to look at the new patch set (#4). Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-09-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: > (2 comments) > > Before I responded to individual comments I wanted to point out >

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called If

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 6: Code-Review+2 Thanks Alex. Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 8: (1 comment)

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe,

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. Patch Set 1: (1 comment) Agree that this maybe isn't a fix so much as an

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called

2016-09-15 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4428 Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called .. IMPALA-4138: Fix AcquireState() for

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into PAGG/AGG IR code

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into PAGG/AGG IR code .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4074: Configuration items duplicate in template of YARN .. Patch Set 2: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4311 To

[Impala-ASF-CR] IMPALA-4074: Configuration items duplicate in template of YARN

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4074: Configuration items duplicate in template of YARN .. Patch Set 1: I'm going to run tests and merge this. -- To view, visit

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 4: Code-Review+2 Carrying the +2-- was missing changes to the config files for running

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4420 to look at the new patch set (#4). Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4411 To

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (3 comments) Thanks for calling these out mikeb.

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/4/bin/gen_build_version.py

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4353 To

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 6: Code-Review+1 (3 comments) Carry +1

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4420/2/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: (19 comments) Flushing out some more comments, and will move onto the later patch set.

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1 and add support for new OSes

2016-09-15 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4420 to look at the new patch set (#2). Change subject: Bump Kudu version to 1.0-RC1 and add support for new OSes

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File

[Impala-ASF-CR] IMPALA-4053: Address follow up comments for IMPALA-3610

2016-09-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/4306/2/be/src/runtime/coordinator.cc