[Impala-ASF-CR] IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4778 To

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 10: Code-Review+2 Fix data loading for Kudu tables and rebase. Carry MJ's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Hello Michael Brown, Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4327 to look at the new patch set (#10). Change subject: IMPALA-3739: Enable stress tests on Kudu

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4776

[Impala-ASF-CR] IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4778 To

[Impala-ASF-CR] IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT DOP > 0.

2016-10-20 Thread Alex Behm (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4767 to look at the new patch set (#4). Change subject: IMPALA-4285/IMPALA-4286: Fixes for Parquet scanner with MT_DOP > 0.

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4750 To

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 4: (13 comments)

[Impala-ASF-CR] IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 1: (1 comment) Carry +1

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4285: Fix Parquet scanner with MT DOP > 0 and no materialized slots.

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4285: Fix Parquet scanner with MT_DOP > 0 and no materialized slots. .. Patch Set 3: Hold off on reviewing, found some issues. -- To view, visit

[Impala-ASF-CR] IMPALA-4277: remove references for unsupported s3/s3n connectors

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4778 Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors .. IMPALA-4277: remove references for unsupported

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. IMPALA-4329: Prevent crash in scheduler when no backends are registered The scheduler

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. IMPALA-4329: Prevent crash in scheduler when no backends are registered The scheduler

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4329: Prevent crash in scheduler when no backends are registered

2016-10-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4776 Change subject: IMPALA-4329: Prevent crash in scheduler when no backends are registered .. IMPALA-4329: Prevent crash in scheduler when

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 3: Code-Review+1 (1 comment) Thanks! It'll be good to run this through the query

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 2: (9 comments) As we discussed in person, we should call out how this should

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4155: Update default partition when table is altered .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4750 To unsubscribe,

[Impala-ASF-CR] IMPALA-4155: Update default partition when table is altered

2016-10-20 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4750 to look at the new patch set (#5). Change subject: IMPALA-4155: Update default partition when table is altered

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-10-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 1: Lars, are you still working on this? Anything blocking from making progress on the review? -- To

[Impala-ASF-CR] IMPALA-4057:fix webserver interface with 127.0.0.1 when start impala process

2016-10-20 Thread Dan Hecht (Code Review)
Dan Hecht has abandoned this change. Change subject: IMPALA-4057:fix webserver_interface with 127.0.0.1 when start impala process .. Abandoned It looks like this is redundant with https://gerrit.cloudera.org/#/c/4553/. You

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-10-20 Thread Dan Hecht (Code Review)
Dan Hecht has abandoned this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Abandoned It looks like this is redundant with https://gerrit.cloudera.org/#/c/4553/. You can restore if

[Impala-ASF-CR] Minor fixes to remove more "cloudera"s from the code.

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4774 Change subject: Minor fixes to remove more "cloudera"s from the code. .. Minor fixes to remove more "cloudera"s from the code. Change-Id:

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: local tests as well as jenkins are passing.

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the whole code

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-20 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4772 Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. IMPALA-3552: make incremental stats max

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File be/CMakeLists.txt:

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py

[Impala-ASF-CR] IMPALA-4241: remove spurious child queries event

2016-10-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4241: remove spurious child queries event .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4768/1/be/src/service/query-exec-state.cc

[Impala-ASF-CR] IMPALA-3872: allow providing PyPi mirror for python packages

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4770 Change subject: IMPALA-3872: allow providing PyPi mirror for python packages .. IMPALA-3872: allow providing PyPi mirror for python

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4771 Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping

[Impala-ASF-CR] IMPALA-4241: remove spurious child queries event

2016-10-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4768 Change subject: IMPALA-4241: remove spurious child queries event .. IMPALA-4241: remove spurious child queries event

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-20 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4732 To unsubscribe,

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. AnayticExpr.analyze() replaces the

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 4: (13 comments) Flushing out some comments. Haven't looked at tests

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Great, thanks! I'll get this merged for you. -- To view, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Yes, I have walk around other planner tests in this file(but not other files), and

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 4: Code-Review+2 rebased -- To view, visit http://gerrit.cloudera.org:8080/4753 To

[Impala-ASF-CR] IMPALA-4285: Fix Parquet scanner with MT DOP > 0 and no materialized slots.

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4767 Change subject: IMPALA-4285: Fix Parquet scanner with MT_DOP > 0 and no materialized slots. .. IMPALA-4285: Fix Parquet scanner with MT_DOP

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Code-Review+2 Did you check whether the expected output of other planner tests

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has uploaded a new patch set (#3). Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate StmtRewrite lost parentheses of

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Thank you for your patience. -- To view, visit