[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 1: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 8: The previous build was manually aborted because the master branch was

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. Kudu

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4892 To

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA-3771: Expose kudu client timeout and set default The Kudu client timeout was too low for Impala

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4849/2/be/src/exec/kudu-table-sink.cc

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-31 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4758 to look at the new patch set (#11). Change subject: IMPALA-3676: Use clang as a static analysis tool ..

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4409: respect lock order in QueryExecState::CancelInternal()

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4896 Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() .. IMPALA-4409: respect lock order in

[Impala-ASF-CR] IMPALA-4411: Kudu inserts violate lock ordering and could deadlock

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4895 Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock .. IMPALA-4411: Kudu inserts violate lock ordering

[Impala-ASF-CR] IMPALA-4365: Enabling end-to-end tests on a remote cluster

2016-10-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4365: Enabling end-to-end tests on a remote cluster .. Patch Set 7: (20 comments) http://gerrit.cloudera.org:8080/#/c/4769/7/bin/remote_data_load.py

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-10-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4894 Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. IMPALA-4379: Fix and test Kudu table type checking,

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 8: It would be good if Henry could take a final look as well. -- To view,

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4633 To

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Fix distcc instructions to help users know they must set BUILD_FARM While I'm

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4846 To unsubscribe,

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. IMPALA-4340: explain how to install postgresql-9.5 or higher The random query generator

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4868 To

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. Patch Set 1: > Is this ready to merge? I can manually verify it since pre-commit > tests won't

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Patch Set 3: > Is this ready to merge? While we wait for some clean test runs, I > think we

[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py .. IMPALA-4380: Remove 'cloudera' from hostnames in

[Impala-ASF-CR] Remove vim plugin config file from .gitignore

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Remove vim plugin config file from .gitignore .. Remove vim plugin config file from .gitignore Files in be/ get wiped out by clean.sh if they're listed

[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py .. Patch Set 1: Verified+1 +1ing since this only changes a

[Impala-ASF-CR] Fix distcc instructions to help users know they must set BUILD FARM

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix distcc instructions to help users know they must set BUILD_FARM .. Patch Set 3: Is this ready to merge? While we wait for some clean test runs, I think we

[Impala-ASF-CR] IMPALA-4340: explain how to install postgresql-9.5 or higher

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4340: explain how to install postgresql-9.5 or higher .. Patch Set 1: Is this ready to merge? I can manually verify it since pre-commit tests won't test

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-31 Thread anujphadke (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4633 to look at the new patch set (#8). Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4893 Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. IMPALA-4410: Safer tear-down of RuntimeState * Add

[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples." .. Abandoned Proper fix being merged now. -- To view, visit http://gerrit.cloudera.org:8080/4890 To

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4892

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Alex Behm (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4892 to look at the new patch set (#2). Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

[Impala-ASF-CR] IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4408: Omit null bytes for Kudu scans with no nullable slots. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-1286: Extract common conjuncts from disjunctions.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. .. Abandoned Putting this on hold for now. -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe,

[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples." .. Patch Set 1: Code-Review-2 I think I've figured out the problem, and it's easy enough to fix.

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-10-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."

2016-10-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples." .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4890 To

[Impala-ASF-CR] IMPALA-3724: Support Kudu non-covering range partitions

2016-10-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3724: Support Kudu non-covering range partitions .. IMPALA-3724: Support Kudu non-covering range partitions This commit adds support for

[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4890 Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples." .. Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4863/5/be/src/exec/hdfs-table-sink.cc

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-10-31 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 1: (3 comments) Thanks for the reviews.

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4379: Fix and test Kudu table type checking .. IMPALA-4379: Fix and test Kudu table type checking Creating Kudu tables shouldn't allow types not

[Impala-ASF-CR] IMPALA-4314: Standardize on MT-related data structures

2016-10-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4314: Standardize on MT-related data structures .. IMPALA-4314: Standardize on MT-related data structures This removes the data structures that

[Impala-ASF-CR] IMPALA-4352: test infra: store Impala/Kudu primary keys in object model

2016-10-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4336: Cast exprs after unnesting union operands.

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4336: Cast exprs after unnesting union operands. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4815 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4330: Fix JSON syntax in generate metrics.py

2016-10-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4330: Fix JSON syntax in generate_metrics.py .. Patch Set 1: Code-Review+2 Thank you, Lars! -- To view, visit http://gerrit.cloudera.org:8080/4887 To

[Impala-ASF-CR] IMPALA-4330: Fix JSON syntax in generate metrics.py

2016-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4330: Fix JSON syntax in generate_metrics.py .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4887 To unsubscribe, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-31 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe, visit