[Impala-ASF-CR] IMPALA-4283: Ensure Kudu-specific lineage and audit behavior

2016-11-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5151 Change subject: IMPALA-4283: Ensure Kudu-specific lineage and audit behavior .. IMPALA-4283: Ensure Kudu-specific lineage and

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#7). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6,

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. IMPALA-4509: Initialise Sasl-specific mutex Call sasl_set_mutex() to configure Sasl library with an

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: -Verified Looks like I can't, so I'll run it through gvo again anyway. -- To view,

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: Verified+1 Build failed with 'table already exists' bug - IMPALA-3641 Everything

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-18 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5105 to look at the new patch set (#5). Change subject: IMPALA-4432: Handle internal codegen disabling properly ..

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-11-18 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Patch Set 1: (8 comments) Ah, sorry. I saw there are other commits targeting more than one issues. What

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-18 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#10). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There

[Impala-ASF-CR] IMPALA-4511: Add missing total time counter() to PFE::Exec()

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5149 Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec() .. IMPALA-4511: Add missing total_time_counter() to

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-18 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. TODO: - Show column encoding and

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+2 I did a smoke test and it looks OK, we should still keep an eye out in perf runs, of

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Let me know when that build passes, and I'll submit this for GVO. -- To view, visit

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: Code-Review+2 carrying +2, rebased -- To view, visit

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5144 Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. IMPALA-4357: Fix DROP TABLE for externally

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5138 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the toolchain build and Kudu version

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: > That seems possible. I never understood how the status didn't show

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: That seems possible. I never understood how the status didn't show

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4968/6/be/src/exec/parquet-column-readers.cc File

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4956/7/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/5105/4/be/src/exec/exchange-node.cc File

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 1: (20 comments) First wave of comments. Will look at tests next.

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5127/3/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. IMPALA-4494: Fix crash in SimpleScheduler The scheduler maintains a local list of active backends, which is updated

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 3: gvm failed because it needs to go in after the change the bumps the kudu version,

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: I'm kicking off a private build w/ my changes and I'm including this. I'll do a smoke test on a

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5142 Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. IMPALA-4509: Initialise Sasl-specific mutex Call sasl_set_mutex() to

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#6). Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 4: (2 comments) Just saw PS4 (which invalidates some of my PS3 comments).

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. IMPALA-4497: Fix Kudu client crash w/ SASL initialization Kudu commit

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. Patch Set 1: (7 comments) Thanks for doing this. Nice! IMPALA-3726 is checked in, so

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 3: (4 comments) It would still be nice to remove the situation between the first topic update and the

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. IMPALA-4494: Fix crash in SimpleScheduler The scheduler maintains a local list of active backends, which is updated

[Impala-ASF-CR] WIP add local backend to backend list if it is not empty

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: WIP add local backend to backend list if it is not empty .. Abandoned Erroneous push, will squash into the parrent change. Apologies for the noise. -- To view, visit

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 3: > I think it would make sense to add the local backend to the list of > backends at the same time as we

[Impala-ASF-CR] WIP add local backend to backend list if it is not empty

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5140 Change subject: WIP add local backend to backend list if it is not empty .. WIP add local backend to backend list if it is not empty

[Impala-ASF-CR] Preview: IMPALA-4467: Add support for CRUD operations in stress test

2016-11-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Preview: IMPALA-4467: Add support for CRUD operations in stress test .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 3: I think it would make sense to add the local backend to the list of backends at the same time as we

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 15: (5 comments) Thanks for the comments, please see PS16.

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-18 Thread Lars Volker (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#16). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5138 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 1: Thank you for your comments. I modified the change to always schedule at the coordinator if

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. IMPALA-4494: Fix crash in SimpleScheduler The scheduler maintains a local list of active backends, which is updated

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. IMPALA-4494: Fix crash in SimpleScheduler The scheduler maintains a local list of active backends, which is updated

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5138 Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-18 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 9: Use clang-format-diff.py to correct code format. -- To view, visit

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-18 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#9). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow There

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-18 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5026 To unsubscribe,

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-18 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. IMPALA-4510: Selectively filter args for metric verification tests run-tests.py is a wrapper