[Impala-ASF-CR] IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

2016-12-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally. .. Patch Set 2: (4 comments) Is the motivation of this change to get Jenkins jobs

[Impala-ASF-CR] IMPALA-4611: Checking perms on S3 files is a very expensive no-op

2016-12-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op .. Patch Set 1: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

2016-12-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally. .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

2016-12-09 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#2). Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally. .. IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

[Impala-ASF-CR] IMPALA-4639: Add pytest option and skip markers for tests that only run locally.

2016-12-09 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and skip markers for tests that only run locally. .. Patch Set 1: (8 comments)

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-09 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5453 Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. IMPALA-4640: Fix number of rows displayed by

[Impala-ASF-CR] IMPALA-4611: Checking perms on S3 files is a very expensive no-op

2016-12-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5449

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5390 To

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables Change-Id:

[Impala-ASF-CR] IMPALA-4638: Run queries with MT DOP through admission control.

2016-12-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4638: Run queries with MT_DOP through admission control. .. Patch Set 2: Code-Review+2 rebase, carry +1, I talked to Dan and he said I should go ahead and

[Impala-ASF-CR] IMPALA-4638: Run queries with MT DOP through admission control.

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4638: Run queries with MT_DOP through admission control. .. Patch Set 1: Code-Review+1 I don't think I know the code well enough to fully understand the

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5334 To

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. IMPALA-4566: Kudu client glog contention can cause timeouts Under stressful

[Impala-ASF-CR] IMPALA-4638: Run queries with MT DOP through admission control.

2016-12-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4638: Run queries with MT_DOP through admission control. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5447 To

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-09 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5093 To unsubscribe,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-09 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#4). Change subject: IMPALA-4467: Add support for DML statements in stress test ..

[Impala-ASF-CR] IMPALA-4611: Checking perms on S3 files is a very expensive no-op

2016-12-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5449 Change subject: IMPALA-4611: Checking perms on S3 files is a very expensive no-op .. IMPALA-4611: Checking perms on S3 files is a very

[Impala-ASF-CR] Add pytest option and skip markers for tests that only run locally.

2016-12-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Add pytest option and skip markers for tests that only run locally. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5446/1/tests/common/skip.py

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Code-Review+1 I'm not going to stand in the way of progress, but for the record: - We have no root

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 2: (11 comments)

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 2: If they're relying on twos-complement we could just cast to unsigned for

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-09 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 4: (9 comments)

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2016-12-09 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 5: Code-Review+2 Rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4418 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situations like hash

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 13: Rebased onto the change that moves bufferpool/ under runtime/ -- To view, visit

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (3 comments) Sorry for the slow turnaround, got caught up in things.

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situations like hash

[Impala-ASF-CR] IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables

2016-12-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4403: Implement SHOW RANGE PARTITIONS for Kudu tables .. Patch Set 11: Code-Review+1 Rebased, ran ParserTest, AnalyzeDDLTest, kudu_alter.test and

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] Bump Kudu server version to latest master (a70c905006)

2016-12-09 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Bump Kudu server version to latest master (a70c905006) .. Bump Kudu server version to latest master (a70c905006) This also re-enabled

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5434

[Impala-ASF-CR] IMPALA-4630: remove debug webpage easter egg

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4630: remove debug webpage easter egg .. IMPALA-4630: remove debug webpage easter egg Change-Id: Ic2b1eb876dcec71a56bf76ea5f045818c6cd9a78

[Impala-ASF-CR] IMPALA-4630: remove debug webpage easter egg

2016-12-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4630: remove debug webpage easter egg .. Patch Set 3: Code-Review+2 carry +2 from dan -- To view, visit http://gerrit.cloudera.org:8080/5429 To

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-12-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-09 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-09 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2016-12-09 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 12: Code-Review+2 fixed merge accidents -- To view, visit

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-09 Thread Marcel Kornacker (Code Review)
Hello Impala Public Jenkins, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4418 to look at the new patch set (#12). Change subject: IMPALA-4014: Introduce query-wide execution state.