[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. Patch Set 1: PS1 was missing word in a comment. -- To view, visit

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. IMPALA-5008: Fix reading stats for TINYINT and SMALLINT TINYINT and SMALLINT types use 1 and 2 byte slots

[Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/6226 Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT .. IMPALA-5008: Fix reading stats for TINYINT and SMALLINT

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6132 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 9: Zach, could you please hold on this until responding to my issues from Feb 17? -- To view, visit

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5902/9/be/src/util/decimal-util.h File

[Impala-ASF-CR] IMPALA-4624: Implement Parquet dictionary filtering

2017-03-02 Thread Joe McDonnell (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5904 to look at the new patch set (#19). Change subject: IMPALA-4624: Implement Parquet dictionary filtering

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6146 To

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/56/ -- To

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references

2017-03-02 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references .. Patch Set 5: Code-Review+2 Didn't run into any issues rebasing against asf-master. Going to try merging

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 8: (1 comment) Also fixing the too long lines

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4946: fix hang in BufferPool .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6224/1//COMMIT_MSG Commit Message: PS1, Line 11: before

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/15/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues

2017-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues .. IMPALA-4593,IMPALA-4635: fix some python build issues Build C/C++ packages with toolchain GCC to avoid

[Impala-ASF-CR] IMPALA-4946: fix hang in BufferPool

2017-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6224 Change subject: IMPALA-4946: fix hang in BufferPool .. IMPALA-4946: fix hang in BufferPool Once the write is removed from the "in

[Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.

2017-03-02 Thread Nathan Salmon (Code Review)
Nathan Salmon has posted comments on this change. Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields. .. Patch Set 4: Thanks for the tests Alex. Apologies for not getting back sooner. It's good to see

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 15: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/15/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 15: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/326/ -- To view,

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6132 to look at the new patch set (#15). Change subject: IMPALA-4813: Round on divide and multiply ..

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-03-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-03-02 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5939/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 14: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/325/ -- To

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. IMPALA-4998: Fix missing table lock acquisition. The following commit broke

[Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe,

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4966: Add flatbuffers to build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6180 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4966: Add flatbuffers to build

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4966: Add flatbuffers to build .. IMPALA-4966: Add flatbuffers to build FlatBuffers version 1.6.0 is already included in the toolchain.

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 14: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/325/ -- To view,

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 14: Code-Review+2 Some test cases needed updating for divide and average rounding. Zach, please double check

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Dan Hecht (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6132 to look at the new patch set (#14). Change subject: IMPALA-4813: Round on divide and multiply ..

<    1   2