[Impala-ASF-CR] IMPALA-5246: MemTestClose() should handle Expr's preparation failure

2017-05-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5246: MemTestClose() should handle Expr's preparation failure .. Patch Set 6: Code-Review+2 This version looks okay to me but please give other reviews a

[Impala-ASF-CR] IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6610 To

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5080: OutOfMemory PermGen space .. IMPALA-5080: OutOfMemory PermGen space A previous fix for this increased the MaxPermGen size.

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6790 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5167: Use a single Kudu client across the BE

2017-05-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6792 Change subject: IMPALA-5167: Use a single Kudu client across the BE .. IMPALA-5167: Use a single Kudu client across the BE

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 1: i'll take this. -- To view, visit http://gerrit.cloudera.org:8080/6789 To

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (2 comments) done with the comments.

[Impala-ASF-CR] Make TimestampValue packed and change the field order

2017-05-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: Make TimestampValue packed and change the field order .. Abandoned this change was superceded -- To view, visit http://gerrit.cloudera.org:8080/6048 To

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 17: I think the interaction between the hint and clause confused me at some point. I'll take another

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: Quick question. Is there a reason why we don't remove the sortby hint in this patch? -- To view,

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-03 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#9). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 9: Code-Review+2 Had to change a new instance of TimestampValue::DebugString -> ToString

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6510 to look at the new patch set (#9). Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/531/ -- To view, visit

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Code-Review+2 Oooo, nice catch! -- To view, visit http://gerrit.cloudera.org:8080/6790 To unsubscribe,

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6790 Change subject: IMPALA-5080: OutOfMemory PermGen space .. IMPALA-5080: OutOfMemory PermGen space A previous fix for this

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#17). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166:

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-03 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#16). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166:

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 8: (56 comments) http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/aggregation-node.h File

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (4 comments) quick feedback just for the tests.

[Impala-ASF-CR] IMPALA-5246: MemTestClose() should handle Expr's preparation failure

2017-05-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5246: MemTestClose() should handle Expr's preparation failure .. Patch Set 5: (6 comments) The existing code wasn't quite consistent about checking for

[Impala-ASF-CR] IMPALA-5246: MemTestClose() should handle Expr's preparation failure

2017-05-03 Thread Michael Ho (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6757 to look at the new patch set (#5). Change subject: IMPALA-5246: MemTestClose() should handle Expr's preparation failure

[Impala-ASF-CR] IMPALA-5246: MemTestClose() should handle Expr's preparation failure

2017-05-03 Thread Michael Ho (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6757 to look at the new patch set (#4). Change subject: IMPALA-5246: MemTestClose() should handle Expr's preparation failure

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Michael Ho (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6757 to look at the new patch set (#2). Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 8: Code-Review+2 rebase, fixed a merge conflict -- To view, visit

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#11). Change subject: IMPALA-2550: Switch to per-query exec rpc .. IMPALA-2550: Switch to per-query exec rpc Coordinator: - FragmentInstanceState -> BackendState, which in turn

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-05-03 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 10: (72 comments)

[Impala-ASF-CR] IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()

2017-05-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()

2017-05-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() .. Patch Set 7: Code-Review+2 (1 comment) Carry +2 given Alex signed off on the new fe changes.

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. Patch Set 1: Free() already has a null check. What am I missing? void

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6526/5//COMMIT_MSG