[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-10-06 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. ( http://gerrit.cloudera.org:8080/7353 ) Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 4: (4 comments) addressed more co

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-10-06 Thread sandeep akinapelli (Code Review)
Hello Matthew Jacobs, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7353 to look at the new patch set (#4). Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW ...

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-29 Thread sandeep akinapelli (Code Review)
Hello Matthew Jacobs, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7353 to look at the new patch set (#3). Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW ...

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-29 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. ( http://gerrit.cloudera.org:8080/7353 ) Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 3: (12 comments) review comments

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-18 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. Patch Set 2: (13 comments) Addressed review comments. http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-09-18 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#2). Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW Added code to read the

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-08-29 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 2: (12 comments) Addressed review comments. http://gerrit.cloudera.org:8080/#/c/7313/2/be/src/exprs/ud

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-08-29 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#3). Change subject: IMPALA-5317: add DATE_TRUNC() function .. IMPALA-5317: add DATE_TRUNC() function Added a UDF builtin function date_trunc. Reuse many of the Trunc functions im

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-08-27 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 2: (7 comments) addressed review comments. http://gerrit.cloudera.org:8080/#/c/7313/1/be/src/exprs/exp

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-08-27 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#2). Change subject: IMPALA-5317: add DATE_TRUNC() function .. IMPALA-5317: add DATE_TRUNC() function Added a UDF builtin function date_trunc. Reuse many of the Trunc functions im

[Impala-ASF-CR] IMPALA-2636: HS2 GetTables() returns TABLE TYPE as TABLE for VIEW

2017-07-03 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new change for review. http://gerrit.cloudera.org:8080/7353 Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW .. IMPALA-2636: HS2 GetTables() returns TABLE_TYP

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-28 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 9: (1 comment) changed the testcase to include OR clause with another column

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-28 Thread sandeep akinapelli (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7110 to look at the new patch set (#9). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-06-27 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new change for review. http://gerrit.cloudera.org:8080/7313 Change subject: IMPALA-5317: add DATE_TRUNC() function .. IMPALA-5317: add DATE_TRUNC() function Added a UDF builtin function date_

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-27 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 8: Fixed test cases by new checking in the new plan after OR to IN conversion

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-27 Thread sandeep akinapelli (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7110 to look at the new patch set (#8). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 6: (2 comments) addressed comments. http://gerrit.cloudera.org:8080/#/c/7110

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7110 to look at the new patch set (#6). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate ..

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 5: (4 comments) addressed review comments http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-15 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#5). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introduces a

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 4: (17 comments) Thanks for the detailed review. addressed review comments.

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#4). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introduces a