[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsubscribe,

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. IMPALA-2605: Omit the sort and mini stress tests These stress tests were sometimes causing

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/151/ -- To

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Code-Review+2 rebase carry TIm's +2 -- To view, visit http://gerrit.cloudera.org:8080/5401 To

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5401 to look at the new patch set (#4). Change subject: IMPALA-2605: Omit the sort and mini stress tests ..

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: > I'm ok with this change but I think we should add the logging in > case we hit the problem on

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-05 Thread Jim Apple (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5401 to look at the new patch set (#3). Change subject: IMPALA-2605: Omit the sort and mini stress tests ..

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: I'm ok with this change but I think we should add the logging in case we hit the problem on

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-03 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > > Maybe we should dump out the value of some of these metrics > before > > running the tests in

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > Maybe we should dump out the value of some of these metrics before > running the tests in

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: I guess I'm uneasy that we don't fully understand the cause of the problem. It seems like it's

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-09 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Code-Review+1 I'm not going to stand in the way of progress, but for the record: - We have no root

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > One option we should consider is replacing this test with a small > run of our "regular" stress

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: One option we should consider is replacing this test with a small run of our "regular" stress test

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > I'm ok with removing these tests if someone can explain to me what > exactly is happening so we

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Code-Review-1 -Verified I'm ok with removing these tests if someone can explain to me what exactly

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: I don't think I've seen these particular tests catch anything. I couldn't find any JIRAs where

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Alex, I think you clicked the wrong button. -1 on Code-Review is for humans, -1 on Verified is for

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Verified-1 I'm against disabling these tests since they are good at finding bugs. Yes, hangs do

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: Code-Review+1 I think Taras should take a look too in case I missed some reason why it would

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-2605: Omit the sort and mini stress tests .. IMPALA-2605: Omit the sort and mini stress tests These stress tests were sometimes causing the end-to-end tests to

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > I think the DDL stress test is still useful, since we don't have > duplicate coverage else.