Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5611
To
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5611
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 12:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/227/
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 12: Code-Review+1
Rebased, replaced NULL with nullptr, removed "// clang-format" control
Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5611
to look at the new patch set (#12).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5611
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
(1 comment)
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
(8 comments)
Thanks for the review. Please see my inline comments and PS11.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5611
to look at the new patch set (#11).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 10:
(9 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5611
to look at the new patch set (#10).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
(17 comments)
Thanks for the review. Please see my inline comments and the new PS.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
(16 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(1 comment)
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 9:
Ran git-clang-format and made the python files more pep8 compliant
--
To view, visit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5611
to look at the new patch set (#9).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 7:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5611
To unsubscribe,
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5611
to look at the new patch set (#8).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 7:
(5 comments)
Thanks for the review. I addressed the open points in PS8.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 7: Code-Review+1
(9 comments)
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(13 comments)
Thanks for the review. Please see PS7.
Lars Volker has uploaded a new patch set (#7).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
(13 comments)
Thanks , I think this will be easier to move forward.
I think to make
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 6:
I removed the support for all but the numerical types from the change. I tried
to keep
Lars Volker has uploaded a new patch set (#6).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 5:
> To make progress here, should this patch be restricted to the
> currently clearly
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 5:
To make progress here, should this patch be restricted to the currently clearly
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
It seems like we really need to talk through the big picture of what to
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(9 comments)
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
*sigh* it seems like there are also some bugs and ambiguities for binary
values:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
We should also think about saving the timestamp stats for a later commit, since
it
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 1:
> > That is really unfortunate that our timestamps are treated as
> byte
> > arrays
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 1:
> That is really unfortunate that our timestamps are treated as byte
> arrays by
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
That is really unfortunate that our timestamps are treated as byte arrays by
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
> > (1 comment)
>
> Apologies for the delayed reply. Hive writes timestamps using
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
> (1 comment)
Apologies for the delayed reply. Hive writes timestamps using 12 bytes
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
Zoltan Ivanfi has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(12 comments)
I need to read through the test code but I thought I'd flush out my
Lars Volker has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 2:
(15 comments)
Thanks for the review, and apologies for the long delay. I ran into
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
Change-Id:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
Patch Set 1:
(15 comments)
I think the overall approach makes sense. I had some higher-level
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5611
Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer
..
IMPALA-3909: Populate min/max statistics in Parquet writer
53 matches
Mail list logo
