[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 13: Code-Review+2 Verified+1 Looks good to me, I'll submit this patch. -- To view,

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#11). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#8). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-20 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: > This needs a committer's look. @Michael, do we know of a committer that has

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: Code-Review+1 This needs a committer's look. -- To view, visit

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#7). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 6: > The hive-default.xml file under > fe/src/test/resources/ is not a valid XML file. It

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 6: > Uploaded patch set 6. Hey Michael, Apologies, yes you are correct, the tests

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#6). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 5: > Uploaded patch set 5: Patch Set 4 was rebased. @Michael, not sure what happened

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: I'd like you to run the small suite of cluster tests, but you can't yet until you rebase