[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Hello Juan Yu, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4516 to look at the new patch set (#4). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+2 (1 comment) Can you give an example of what the old and new metries look like?

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/3/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-23 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: The core change to HistogramMetric (adding a Reset() method) is needed for our proposed

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4516 Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's