[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4969 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. IMPALA-4392: restore PeakMemoryUsage to DataSink profiles The join build sink patches re

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-ge

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 3: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4969 To unsubs

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-16 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4969 to look at the new patch set (#3). Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. IMPALA

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4969 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4969 to look at the new patch set (#2). Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. IMPALA

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 2: I switched to the alternative approach - seems to work out a bit simpler. -- To view,

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 1: Code-Review+2 I see. Since we're going to have this extra layer eventually anyway (when u

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 1: The only real reason is to avoid adding an extra layer of MemTrackers in the join node

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. Patch Set 1: why do the sinks' memtrackers need to be constructed by the PFE rather than the sink thems

[Impala-ASF-CR] IMPALA-4392: restore PeakMemoryUsage to DataSink profiles

2016-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4969 Change subject: IMPALA-4392: restore PeakMemoryUsage to DataSink profiles .. IMPALA-4392: restore PeakMemoryUsage to DataSink profiles T