[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. IMPALA-4432: Handle internal codegen disabling properly There are some conditions in

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5105 To unsubscribe,

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 8: Code-Review+2 Carry Dan's +2. -- To view, visit http://gerrit.cloudera.org:8080/5105 To

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5105/7/be/src/runtime/runtime-state.h

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-22 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5105 to look at the new patch set (#8). Change subject: IMPALA-4432: Handle internal codegen disabling properly

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 6: (4 comments) Thanks, this is much easier to follow now. It'd be good for Tim to take

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-18 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5105 to look at the new patch set (#5). Change subject: IMPALA-4432: Handle internal codegen disabling properly ..

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/5105/4/be/src/exec/exchange-node.cc File

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 4: Code-Review+1 Carry Tim's +1 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5105 to look at the new patch set (#4). Change subject: IMPALA-4432: Handle internal codegen disabling properly ..

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4432: Handle internal codegen disabling properly .. IMPALA-4432: Handle internal codegen disabling properly There are some conditions in which codegen is

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5105/2/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4432: Handle internal codegen disabling properly .. IMPALA-4432: Handle internal codegen disabling properly There are some conditions in which codegen is