[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#2). Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types for the decimal round/truncate and related

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. Patch Set 1: Why doesn't this change also pull in the validation of the resulting Decimal types to validate

[Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5959 Change subject: IMPALA-4810: fix incorrect expr-test decimal types .. IMPALA-4810: fix incorrect expr-test decimal types Many of the types