Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5792
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 16: Code-Review+2
Rebased on top of https://gerrit.cloudera.org/#/c/6264/. Carrying Henry's
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 16:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/347/
--
To
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Sounds good - I commented on the bugfix, hopefully we can get these both in
quickly.
--
To
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
@Henry: The GVO of this patch exposed an unrelated bug that I fixed in another
CR [1].
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/319/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/319/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/316/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/316/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/310/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/311/
--
To
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 15: Code-Review+2
Thanks Henry. Rebased and increased the page width to 50% for it look
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5792
to look at the new patch set (#15).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 14: Code-Review+2
Discussed offline. I believe the out-of-the-box behaviour hasn't changed.
--
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc
File
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5792
to look at the new patch set (#14).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
(4 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13: Code-Review+2
(4 comments)
Looks pretty good to me.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 13:
Henry, do you have any further comments on this? Thanks.
--
To view, visit
Bharath Vissapragada has uploaded a new patch set (#13).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 12:
(16 comments)
Fxed a minor bug in the web UI where the setting for java log level
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 12:
> I'm not sure the extra complexity of the UI is worth it.
Without the UI, we'd have to
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 12:
> Marcel, you can make changes like you described just with a URL,
> see test_web_pages.py
Bharath Vissapragada has uploaded a new patch set (#12).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/5792/7/be/src/util/logging-support.cc
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 1:
Rather than using a web page for making those changes, why not simply do it
through a URL?
Bharath Vissapragada has uploaded a new patch set (#11).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Bharath Vissapragada has uploaded a new patch set (#10).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Alex Behm has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift
File
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift
File
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift
Alex Behm has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift
File
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(29 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 7:
(22 comments)
Took a look, had some comments.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 6:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc
Bharath Vissapragada has uploaded a new patch set (#7).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Alex Behm has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 6:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc
File
Bharath Vissapragada has uploaded a new patch set (#6).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 5:
(9 comments)
webserver-test.cc seems to be more unit-testing the WebServer class and I
Alex Behm has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 5:
(9 comments)
Since we're accepting user input it would be great to have unit tests. Checking
that
Bharath Vissapragada has uploaded a new patch set (#5).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4822: Implement dynamic log level changes
..
Patch Set 1:
(2 comments)
PS4 implements dynamic logging changes to the backend (equivalent to
Bharath Vissapragada has uploaded a new patch set (#4).
Change subject: IMPALA-4822: Implement dynamic log level changes
..
IMPALA-4822: Implement dynamic log level changes
Very often we have to change the logging levels
of
48 matches
Mail list logo
