[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Abandoned merging with https://gerrit.cloudera.org/#/c/6526/ -- To view, visit

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6510/11/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 9: Code-Review+2 Had to change a new instance of TimestampValue::DebugString -> ToString

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6510 to look at the new patch set (#9). Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 8: Code-Review+2 rebase, fixed a merge conflict -- To view, visit

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 7: Code-Review+2 sorry for all the rebasing noise, I'm holding off on committing this until

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/425/ --

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. IMPALA-5137: pt1, Refactor TimestampValue constructors In preparation for supporting Kudu TIMESTAMPs,

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 1: (10 comments)

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6510 Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. IMPALA-5137: pt1, Refactor TimestampValue constructors In