[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Michael Ho (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6757 to look at the new patch set (#2). Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. Patch Set 1: Free() already has a null check. What am I missing? void

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-03 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-05-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. Patch Set 1: Code-Review+1 (1 comment) This change makes sense to me.

[Impala-ASF-CR] IMPALA-5246: UDF's Close() should handle Expr's preparation failure

2017-04-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6757 Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation failure .. IMPALA-5246: UDF's Close() should handle Expr's