[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7081 To unsubscri

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. IMPALA-5347: reduce codegen overhead of timestamp trunc() Trunc has many implementa

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/680/ --

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7081 To unsu

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/2/be/src/exprs/udf-builtins.cc Fi

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7081 to look at the new patch set (#3). Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() ...

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/2/be/src/exprs/u

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7081 To unsu

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins.cc Fi

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins-ir.cc Fi

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7081 to look at the new patch set (#2). Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. IMPAL

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins-ir.c

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-bu

[Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()

2017-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7081 Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() .. IMPALA-5347: reduce codegen overhead of timestamp trunc() T