[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-21 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-21 Thread anujphadke (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6778 to look at the new patch set (#4). Change subject: IMPALA-4866: Hash join node does not apply limits correctly ..

[Impala-ASF-CR] IMPALA-4863: Correctly account the file type and compression codec

2017-06-21 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7245 Change subject: IMPALA-4863: Correctly account the file type and compression codec .. IMPALA-4863: Correctly account the file type and

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5488: Fix handling of exclusive HDFS file handles

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5488: Fix handling of exclusive HDFS file handles .. IMPALA-5488: Fix handling of exclusive HDFS file handles This change fixes three

[Impala-ASF-CR] IMPALA-5488: Fix handling of exclusive HDFS file handles

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5488: Fix handling of exclusive HDFS file handles .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7181 To

[Impala-ASF-CR] IMPALA-5537: Retry RPC on somes exceptions with SSL connection

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection .. IMPALA-5537: Retry RPC on somes exceptions with SSL connection After the fix

[Impala-ASF-CR] IMPALA-5537: Retry RPC on somes exceptions with SSL connection

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7229 To

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 3: (7 comments) nice! thanks for adding the test, I think it looks good. I

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7240 to look at the new patch set (#2). Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This patch ports the data-flow parts of ImpalaInternalService to

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#14). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC This patch

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7180 To

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. IMPALA-5497: spilling hash joins that output build rows hit OOM The bug is

[Impala-ASF-CR] IMPALA-5553: Fix expr-test in release builds

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5553: Fix expr-test in release builds .. Patch Set 1: Code-Review+2 Thanks for the cleanup -- To view, visit http://gerrit.cloudera.org:8080/7255 To

[Impala-ASF-CR] IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4703: reservation denial debug action .. IMPALA-4703: reservation denial debug action Add debug action to deny reservation increases with some probability.

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 5: (5 comments) I found a handful of subtle bugs. Most of them were caught

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7240 to look at the new patch set (#3). Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. Patch Set 3: Code-Review+2 Rebase only. Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 5: (22 comments) PS4 is a rebase. PS5 includes the review responses (so diff 4->5 if you want to

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#15). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC This patch

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#9). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version to

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#5). Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This patch ports the data-flow parts of ImpalaInternalService to

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#10). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#10). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu. One minor

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-06-21 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6473 to look at the new patch set (#8). Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs ..

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-21 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5715 to look at the new patch set (#19). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-5540: Revert Sentry version back to 5.13

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5540: Revert Sentry version back to 5.13 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7247 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5540: Revert Sentry version back to 5.13

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5540: Revert Sentry version back to 5.13 .. IMPALA-5540: Revert Sentry version back to 5.13 Sentry has now fixed the problem on their

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/776/ -- To

[Impala-ASF-CR] IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails

2017-06-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7254 Change subject: IMPALA-5551: Fix AggregationNode::Close() when Prepare() fails .. IMPALA-5551: Fix AggregationNode::Close() when Prepare()

[Impala-ASF-CR] IMPALA-5553: Fix expr-test in release builds

2017-06-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7255 Change subject: IMPALA-5553: Fix expr-test in release builds .. IMPALA-5553: Fix expr-test in release builds expr-test fails in release

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: https://gerrit.cloudera.org/#/c/7257/ will also help make the primary key

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load

2017-06-21 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7095 to look at the new patch set (#4). Change subject: IMPALA-5431: Remove redundant path exists checks during table load

[Impala-ASF-CR] PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#21). Change subject: PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool .. PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674: Part 1: remove old aggs and joins This is intended to be merged at the same time as Part 2 but is

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 3: Code-Review+2 Rebased. Keep Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/775/

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7240 To

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7240 To

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7257 Change subject: IMPALA-5547: Rework FK/PK join detection. .. IMPALA-5547: Rework FK/PK join detection. Reworks the FK/PK join detection

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 10: Michael - this includes the KRB5 and OpenSSL linking fixes. -- To view, visit

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-06-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away from

[Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

2017-06-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 3: (8 comments) Rebased onto my latest buffer pool preview patch and addressed comments.

[Impala-ASF-CR] Bump Kudu version to c0798a9

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to c0798a9 .. Bump Kudu version to c0798a9 Change-Id: I3523f2b769cff6ab3a6aac97ec36f6bb3bda5e0f Reviewed-on:

[Impala-ASF-CR] Bump Kudu version to c0798a9

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to c0798a9 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7246 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7248 To unsubscribe,

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: > IIRC, this was introduced because the permanent UDF changes broke >

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7248 to look at the new patch set (#2). Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. IMPALA-5240: Allow config of number of disk I/O threads per disk type Currently Impala

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-06-21 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: Code-Review+1 (1 comment) Ok, Thanks for clarifying.

[Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout .. IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: IIRC, this was introduced because the permanent UDF changes broke some

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: > (1 comment) Thanks Tim. This example makes things clearer. @Henry: The

[Impala-ASF-CR] IMPALA-4863: Correctly account the file type and compression codec

2017-06-21 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4863: Correctly account the file type and compression codec .. Patch Set 2: Defaulting filtered to false in the function definition instead of passing

[Impala-ASF-CR] IMPALA-4863: Correctly account the file type and compression codec

2017-06-21 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-4863: Correctly account the file type and compression codec .. IMPALA-4863: Correctly account the file type and compression codec If a scan range is filtered

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/7153/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-21 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Abandoned Bad merge - will restore when I fix it. -- To view, visit

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7197 To unsubscribe,

[Impala-ASF-CR] IMPALA-5517: Allow IMPALA LOGS DIR to be overridden

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden .. IMPALA-5517: Allow IMPALA_LOGS_DIR to be overridden Tested by exporting a different

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7248 To

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. IMPALA-5549: Remove deprecated fields from CatalogService API Remove from

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7240 To

[Impala-ASF-CR] IMPALA-5548 Fix some minor nits with HDFS parquet column readers

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers .. IMPALA-5548 Fix some minor nits with HDFS parquet column readers Replace

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7022 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away from

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-21 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7226 to look at the new patch set (#5). Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

[Impala-ASF-CR] IMPALA-5553: Fix expr-test in release builds

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5553: Fix expr-test in release builds .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/778/ -- To view,

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7103/3/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] Bump Kudu version to c0798a9

2017-06-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7246 Change subject: Bump Kudu version to c0798a9 .. Bump Kudu version to c0798a9 Change-Id: I3523f2b769cff6ab3a6aac97ec36f6bb3bda5e0f ---

[Impala-ASF-CR] Bump Kudu version to c0798a9

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to c0798a9 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/771/ -- To view, visit

[Impala-ASF-CR] Bump Kudu version to c0798a9

2017-06-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to c0798a9 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7246 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

2017-06-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout .. Patch Set 2: Code-Review+2 rebase to get the sentry fix -- To view, visit

[Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 4: If you rebase I can kick off a merge -- To view, visit

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-06-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-06-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6778 To unsubscribe,

  1   2   >