Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type ......................................................................
Patch Set 3: (7 comments) nice! thanks for adding the test, I think it looks good. I had a few small additional comments, and I realized I think we can simplify disk-io-mgr by removing one of the members. http://gerrit.cloudera.org:8080/#/c/7232/3/be/src/runtime/disk-io-mgr-test.cc File be/src/runtime/disk-io-mgr-test.cc: Line 1142: int num_io_threads_for_remote_disks = FLAGS_num_remote_hdfs_io_threads const PS3, Line 1160: 0 can you also set this to something else, e.g. 100 to show that it gets overwritten by the other parameters? PS3, Line 1165: == weird indentation, just put the operator on the previous line and use 4 spaces to tab http://gerrit.cloudera.org:8080/#/c/7232/3/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: PS3, Line 631: /// comment this is for testing only PS3, Line 638: /// - threads_per_rotational_disk: number of read threads to create per rotational : /// disk. This is also the max queue depth. : /// - threads_per_solid_state_disk: number of read threads to create per solid state : /// disk. This is also the max queue depth. these overwrite threads_per_disk PS3, Line 837: num_threads_per_disk_ the naming of this should probably be num_io_threads_per_disk_ to be consistent or better yet, I think we can remove this member altogether because we can just set num_io_threads_per_{rotational,ssd}_ to the value of FLAGS_num_threads_per_disk if the finer grained flags weren't set. http://gerrit.cloudera.org:8080/#/c/7232/3/be/src/util/thread.cc File be/src/util/thread.cc: PS3, Line 335: const nit: space after const -- To view, visit http://gerrit.cloudera.org:8080/7232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
