[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-09-26 Thread Youwei Wang (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4490 to look at the new patch set (#8). Change subject: IMPALA-3504: UDF for current timestamp in UTC .. IMPALA-3504:

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 6: Will rebase before check-in. -- To view, visit http://gerrit.cloudera.org:8080/4390 To

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#7). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Allow votes to go long if they overlap a weekend. .. Allow votes to go long if they overlap a weekend. On our first release vote, Tom White explained that this is

[Impala-ASF-CR](asf-site) Allow votes to go long is they overlap a weekend.

2016-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Allow votes to go long is they overlap a weekend. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4536/1//COMMIT_MSG Commit Message: PS1,

Re: [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-26 Thread Sahil Takiar
Done, thanks Henry! --Sahil On Mon, Sep 26, 2016 at 3:57 PM, Henry Robinson wrote: > stak...@cloudera.com - Could you please fill out your Gerrit profile? In > the top-right corner there's a drop-down menu with 'settings' as an option. > > That stops you from showing up on

Re: [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-26 Thread Henry Robinson
stak...@cloudera.com - Could you please fill out your Gerrit profile? In the top-right corner there's a drop-down menu with 'settings' as an option. That stops you from showing up on these reviews as 'Anonymous Coward'. On 25 September 2016 at 18:14, Anonymous Coward (Code Review) <

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-26 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 4: Jim - Just waiting on someone to +2 it. You had added Alex to the review last

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/3/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 3: (1 comment) > Any updates? Not yet, will look at this again this week, hopefully

[Impala-ASF-CR] IMPALA-4199: Add 'SNAPSHOT' to Impala version

2016-09-26 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4539 Change subject: IMPALA-4199: Add 'SNAPSHOT' to Impala version .. IMPALA-4199: Add 'SNAPSHOT' to Impala version Unreleased versions should

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 4: Code-Review+1 Carry Dan's +1. Thomas, is this waiting on anything? -- To view, visit

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 3: Any updates? -- To view, visit http://gerrit.cloudera.org:8080/4187 To

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#6). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code ..

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Henry Robinson (Code Review)
Hello Juan Yu, Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4516 to look at the new patch set (#4). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 3: Code-Review+2 (1 comment) Can you give an example of what the old and new metries look like?

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-26 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-09-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4490/7/be/src/exprs/expr-test.cc

[Impala-ASF-CR](asf-site) Allow votes to go long is they overlap a weekend.

2016-09-26 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4536 Change subject: Allow votes to go long is they overlap a weekend. .. Allow votes to go long is they overlap a weekend. On our first release

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-26 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has uploaded a new patch set (#2). Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. IMPALA-784: Use `-s in SHOW CREATE TABLE output Change-Id: I8e66439daa35d2e3725e7277c16f3cc5fdb6f128 --- M

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 19: (12 comments)