[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#8). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 19: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4715 To

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 19: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/123/

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4715 to look at the new patch set (#18). Change subject: IMPALA-3200: Implement suballocator for splitting buffers

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4715 to look at the new patch set (#17). Change subject: IMPALA-3200: Implement suballocator for splitting buffers

[Impala-ASF-CR] IMPALA-4633: Change broken gflag default for Kudu client mem

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4633: Change broken gflag default for Kudu client mem .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5503 To

[Impala-ASF-CR] IMPALA-4633: Change broken gflag default for Kudu client mem

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4633: Change broken gflag default for Kudu client mem .. IMPALA-4633: Change broken gflag default for Kudu client mem We discovered that the

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#8). Change subject: IMPALA-4467: Add support for DML statements in stress test

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 15: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4715 To

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 14: (9 comments)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4715 to look at the new patch set (#15). Change subject: IMPALA-3200: Implement suballocator for splitting buffers ..

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. IMPALA-4639: Add pytest option and xfail markers for tests that

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3202,IMPALA-2298: rework scratch file I/O

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#15). Change subject: IMPALA-3202,IMPALA-2298: rework scratch file I/O .. IMPALA-3202,IMPALA-2298: rework scratch file I/O Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 2: Code-Review+1 Thanks for adding the additional test cases. My +1 means I'm

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5093/4//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#7). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5093/4//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4649: add a mechanism to pass flags into make .. Patch Set 2: Code-Review+1 Rebased, carry +1 -- To view, visit http://gerrit.cloudera.org:8080/5480 To

[Impala-ASF-CR] IMPALA-4649: add a mechanism to pass flags into make

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5480 to look at the new patch set (#2). Change subject: IMPALA-4649: add a mechanism to pass flags into make ..

[Impala-ASF-CR] IMPALA-4659: fuzz test fixes

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4659: fuzz test fixes .. IMPALA-4659: fuzz test fixes * Apply a 512m mem_limit to all fuzz tests. This limits aggregate memory

[Impala-ASF-CR] IMPALA-4659: fuzz test fixes

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4659: fuzz test fixes .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5502 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5093/6/tests/stress/concurrent_select.py

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5093 to look at the new patch set (#6). Change subject: IMPALA-4467: Add support for DML statements in stress test ..

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-14 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4467: Add support for DML statements in stress test .. Patch Set 4: (1 comment)

[Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService

2016-12-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5507 Change subject: CDH-48291: Fix flaky test TestRequestPoolService .. CDH-48291: Fix flaky test TestRequestPoolService This

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5505 to look at the new patch set (#2). Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 6: Verified+1 http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/121/

[Impala-ASF-CR] IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5505 Change subject: IMPALA-4662: Fix NULL literal handling in Kudu IN list predicates .. IMPALA-4662: Fix NULL literal handling in Kudu IN

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Add all build targets to CMake and speed up builds .. Add all build targets to CMake and speed up builds Use CMake's dependency resolution

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] IMPALA-4648: remove build thirdparty.sh

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4648: remove build_thirdparty.sh .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5477 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4648: remove build thirdparty.sh

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4648: remove build_thirdparty.sh .. IMPALA-4648: remove build_thirdparty.sh It is not needed by any build processes. Change-Id:

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5493 To unsubscribe,

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. IMPALA-4654: KuduScanner must return when ReachedLimit() Fixes a bug in the KuduScanner

[Impala-ASF-CR] IMPALA-4659: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4659: fuzz test fixes .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5502 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4659: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4659: fuzz test fixes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5502/2//COMMIT_MSG Commit Message: PS2, Line 7: IMPALA-4569 >

[Impala-ASF-CR] IMPALA-4659: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5502 to look at the new patch set (#3). Change subject: IMPALA-4659: fuzz test fixes .. IMPALA-4659: fuzz test fixes *

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4569: fuzz test fixes .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5502/2//COMMIT_MSG Commit Message: PS2, Line 7: IMPALA-4569 wrong

[Impala-ASF-CR] IMPALA-4633: Change broken gflag default for Kudu client mem

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4633: Change broken gflag default for Kudu client mem .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5503/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4633: Change broken gflag default for Kudu client mem

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4633: Change broken gflag default for Kudu client mem .. IMPALA-4633: Change broken gflag default for Kudu client mem We discovered that the current Kudu

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4630: Change broken gflag default for Kudu client mem

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4630: Change broken gflag default for Kudu client mem .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5503/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4569: fuzz test fixes .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/122/ -- To view, visit

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread David Knupp (Code Review)
Hello Michael Brown, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5446 to look at the new patch set (#4). Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4569: fuzz test fixes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5502 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4715 to look at the new patch set (#14). Change subject: IMPALA-3200: Implement suballocator for splitting buffers ..

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 14: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4715 To

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4569: fuzz test fixes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5502/1/tests/query_test/test_scanners_fuzz.py File

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4569: fuzz test fixes .. IMPALA-4569: fuzz test fixes * Apply a 512m mem_limit to all fuzz tests. This limits aggregate memory consumption to ~5GB per

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/120/ -- To

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: > Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/120/ Sorry, that was me

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] IMPALA-4630: Change broken gflag default for Kudu client mem

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4630: Change broken gflag default for Kudu client mem .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5503/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4569: fuzz test fixes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5502/1/tests/query_test/test_scanners_fuzz.py File

[Impala-ASF-CR] IMPALA-4630: Change broken gflag default for Kudu client mem

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4630: Change broken gflag default for Kudu client mem .. Patch Set 1: In addition to stress testing and the 200 node tests from Mostafa, this also

[Impala-ASF-CR] IMPALA-4630: Change broken gflag default for Kudu client mem

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5503 Change subject: IMPALA-4630: Change broken gflag default for Kudu client mem .. IMPALA-4630: Change broken gflag default for Kudu

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4790 To unsubscribe,

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/118/ -- To

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/117/ -- To

[Impala-ASF-CR] IMPALA-4648: remove build thirdparty.sh

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4648: remove build_thirdparty.sh .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5477 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4648: remove build thirdparty.sh

2016-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4648: remove build_thirdparty.sh .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/116/ -- To view, visit

[Impala-ASF-CR] IMPALA-4569: fuzz test fixes

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5502 Change subject: IMPALA-4569: fuzz test fixes .. IMPALA-4569: fuzz test fixes * Apply a 512m mem_limit to all fuzz tests. This limits

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5491/1/be/src/runtime/data-stream-mgr.cc File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: > Maybe we should dump out the value of some of these metrics before > running the tests in

[Impala-ASF-CR] IMPALA-4163: Add sortby() query hint

2016-12-14 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4163: Add sortby() query hint .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/5051/3/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2016-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 2: I guess I'm uneasy that we don't fully understand the cause of the problem. It seems like it's

[Impala-ASF-CR] IMPALA-4631: don't use floating point operations for time unit conversions

2016-12-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4631: don't use floating point operations for time unit conversions .. Patch Set 6: Code-Review+2 Rebase -- To view, visit

[Impala-ASF-CR] IMPALA-4640: Fix number of rows displayed by parquet-reader tool

2016-12-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4640: Fix number of rows displayed by parquet-reader tool .. IMPALA-4640: Fix number of rows displayed by parquet-reader tool The variable just never got

[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2016-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 1: I'll do the first round of reviews. -- To view, visit http://gerrit.cloudera.org:8080/5491 To

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

2016-12-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: > Change looks good to me. > > As discussed, I think there is still one remaining

[Impala-ASF-CR] IMPALA-4639: Add pytest option and xfail markers for tests that only run locally.

2016-12-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4639: Add pytest option and xfail markers for tests that only run locally. .. Patch Set 3: (1 comment)