[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
..


Patch Set 1:

(3 comments)

I'm taking over the patch and will update it soon.

http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

PS1, Line 225:   // TODO: instead of adding them here and subtracting errors in 
CheckForErrors,
 :   // would it be better to _set_ the value to the total number 
of written rows
 :   // minus the errors minus the current buffer size?
> Todd: Can we even get the current buffer size?
On second though, I don't think we care about updating this constantly. We can 
just update it once in FinalFlush with total num written - total num errors.


PS1, Line 234:   if (session_->CountPendingErrors() == 0) {
 : return Status::OK();
 :   }
> nit: 1 line
Done


PS1, Line 281:   // TODO: these counters don't make so much sense anymore.
 :   SCOPED_TIMER(kudu_flush_timer_);
 :   COUNTER_ADD(kudu_flush_counter_, 1);
> can you remove them then?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

PS1, Line 225:   // TODO: instead of adding them here and subtracting errors in 
CheckForErrors,
 :   // would it be better to _set_ the value to the total number 
of written rows
 :   // minus the errors minus the current buffer size?
> Yeah, this is a bit weird as it is. I'd vote to compute this as you describ
Todd: Can we even get the current buffer size?

I was looking at CountBufferedOperations() but that doesn't appear to be what 
we'd want here. (Doc says it applies to MANUAL flush only.)


-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

[Todd Lipcon (Code Review)]

Todd Lipcon has uploaded a new patch set (#2).

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
..

WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink

Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
---
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/kudu-table-sink.h
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
7 files changed, 73 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/4670/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Todd Lipcon 

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

[Matthew Jacobs (Code Review)]

Matthew Jacobs has posted comments on this change.

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

PS1, Line 176: SetString
> It does result in an extra copy, which is unfortunate, but it's not safe ot
Ok, I agree that sounds complicated. On the other hand, I wonder if a very 
string heavy workload will be worth using AUTO_FLUSH_BACKGROUND. I guess we'll 
have to test it to see.


-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

[Todd Lipcon (Code Review)]

Hello Matthew Jacobs,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4670

to review the following change.

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
..

WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink

Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
---
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/kudu-table-sink.h
3 files changed, 31 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/4670/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Matthew Jacobs