Matthew Jacobs has posted comments on this change.

Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc
File be/src/exec/kudu-table-sink.cc:

PS1, Line 225:   // TODO: instead of adding them here and subtracting errors in 
CheckForErrors,
             :   // would it be better to _set_ the value to the total number 
of written rows
             :   // minus the errors minus the current buffer size?
> Yeah, this is a bit weird as it is. I'd vote to compute this as you describ
Todd: Can we even get the current buffer size?

I was looking at CountBufferedOperations() but that doesn't appear to be what 
we'd want here. (Doc says it applies to MANUAL flush only.)


-- 
To view, visit http://gerrit.cloudera.org:8080/4670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to