[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 4: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/5950

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 4: Added decimal_v2 as a test dimension for decimal_casting.py. It's disabled for now as we

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5950 to look at the new patch set (#4). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 ..

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5950 to look at the new patch set (#3). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 ..

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 2: Verified there is no perf regression with decimal_v2=false using following query: select

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 2: Code-Review+2 (2 comments) Please take a look at whether it makes sense to add coverage in

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: We also have test_decimal_casting.py. I haven't looked at it in detail but maybe there's

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/5950/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2

2017-02-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 .. IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2 Currently, codegen supports converting type