[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5343 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parq

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 2: Code-Review+2 Carrying the +2. -- To view, visit http://gerrit.cloudera.org:8080/5343 To unsu

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5343/1/be/src/runtime/timestamp-value.h File b

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5343 to look at the new patch set (#2). Change subject: IMPALA-4363: Add Parquet timestamp validation

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 1: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5343/1/be/src/runtime/timestamp-valu

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 1: The previous review https://gerrit.cloudera.org/#/c/4968/ has been abandoned because I deleted

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5343 Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4968/9/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-12-02 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#10). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4968/9/be/src/exec/parquet-column-readers.cc File

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet timest

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add P

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add P

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add P

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/8/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/8/be/src/exec/parquet-column-readers.cc File be/

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/4968/7/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-23 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#8). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add P

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/4968/7/be/src/exec/parquet-column-readers.cc File be/

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#7). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add P

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6, Lin

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4968/6/be/src/exec/parquet-column-readers.cc File be/

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6, Line

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6, Line 12: di

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6/testdata/bad_parquet_data/README File t

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4968 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/5/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet timest

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 5: (4 comments) Almost ready for +1 http://gerrit.cloudera.org:8080/#/c/4968/5/be/src/exec/parquet-colum

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#5). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet timest

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/4968/4/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/4968/4/be/src/exec/parquet-column-readers.cc File be

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/4/tests/query_test/test_scanners.py File

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/4/be/src/exec/parquet-column-readers.cc F

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-10 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet timest