[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 03 Oct 2017 01:33:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Reviewed-on: http://gerrit.cloudera.org:8080/8164 Reviewed-by: Dan HechtTested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 6: Code-Review+2 Carrying forward Lars' +2. -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 02 Oct 2017 22:32:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1286/ -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 02 Oct 2017 21:31:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 6: (1 comment) Can you re-run the jenkins test? It failed because of TestKuduClientTimeout.test_catalogd_timeout, which was removed in https://github.com/cloudera/Impala/commit/fc54882d9a4769263d800d0654048f0ab1252153 , so I hope that the rebase has solved the issue. http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc@103 PS4, Line 103: be w > Remove "only", since it conflicts with the following sentence. Done -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 02 Oct 2017 18:10:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1278/ -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 21:08:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1278/ -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 17:05:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#5). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 --- M be/src/common/global-flags.cc 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/8164/5 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 16:52:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc@103 PS4, Line 103: only Remove "only", since it conflicts with the following sentence. -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 16:32:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: I'll let Lars give a +2 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 16:25:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: Code-Review+1 (1 comment) Linking doesn't seem necessary to me - I think the documentation is easily discoverable by search (both the wiki page and the docs themselves) http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc@105 PS4, Line 105: "to create minidumps on demand without exiting the process by sending SIGUSR1. " Thanks this is better than my suggestion. -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 16:25:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: Would it be a good idea to refer cwiki.apache.org/confluence/display/IMPALA/Debugging+Impala+Minidumps in the help string? (By the way sorry for the large number of small patches.) -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 29 Sep 2017 16:08:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#4). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 --- M be/src/common/global-flags.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/8164/4 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#3). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 --- M be/src/common/global-flags.cc 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/8164/3 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#2). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 --- M be/src/common/global-flags.cc 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/8164/2 -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba RinghoferGerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong