[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-11 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-09 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5933 To

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. IMPALA-4810: Make DECIMAL expr-test cases table driven That way, we can easily run

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/246/ --

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Code-Review+2 (1 comment) Carry Michael's +2.

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Hello Michael Ho, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5933 to look at the new patch set (#3). Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Hello Michael Ho, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5933 to look at the new patch set (#2). Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 Looks pretty straightforward -- To view, visit