[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6963 To

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Code-Review+2 carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 12: Removed the preconditions check - it was too strict for the case when the hash

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6963 to look at the new patch set (#12). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: PS 10 is a rebase and commit message update -- To view, visit

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: (1 comment) Any thoughts?

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 8: Cleaned up this patch, removing the increased explain level of the existing

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-06-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 6: > I think it might be best, if possible, to agree on the planner > mechanism first

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 6: The main scenario where it could lead to additional spilling (assuming

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 6: I updated the patchset to use explain_level EXTENDED for TPC-H and TPC-DS. This

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 5: (1 comment) Yes I agree it would be interesting to look at. One option is to

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 4: (1 comment) Would be interesting to see how this works on some real datasets.

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. Patch Set 4: Posting for discussion. The approach used is quite simple. The main risk of

[Impala-ASF-CR] IMPALA-5160: adjust spill buffer size based on planner estimates

2017-05-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5160: adjust spill buffer size based on planner estimates .. IMPALA-5160: adjust spill buffer size based on planner estimates Scale down the buffer size in