[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were only evaluated for the first fragment instance. However, for a union inside a subplan, we should always evaluate the constant exprs. Testing: - Added a regression test. - Locally ran test_nested_types.py and the union tests in test_queries.py Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Reviewed-on: http://gerrit.cloudera.org:8080/7091 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M be/src/exec/union-node.cc M be/src/exec/union-node.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test 3 files changed, 18 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/688/ -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Alex Behm has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7091 to look at the new patch set (#3). Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were only evaluated for the first fragment instance. However, for a union inside a subplan, we should always evaluate the constant exprs. Testing: - Added a regression test. - Locally ran test_nested_types.py and the union tests in test_queries.py Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 --- M be/src/exec/union-node.cc M be/src/exec/union-node.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test 3 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7091/3 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
anujphadke has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: anujphadke Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were only evaluated for the first fragment instance. However, for a union inside a subplan, we should always evaluate the constant exprs. Testing: - Added a regression test. - Locally ran test_nested_types.py and the union tests in test_queries.py Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 --- M be/src/exec/union-node.cc M be/src/exec/union-node.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test 3 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7091/2 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: anujphadke
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Alex Behm has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7091/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test: Line 592: QUERY > I think we should validate the results of this query. Maybe check the num This test is crafted such that we expect an empty result set. In the old buggy code, this query returned a non-empty result set. I verified that this test fails without the fix. I expanded the comment to explain what result we expect. -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
anujphadke has posted comments on this change. Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7091/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test: Line 592: QUERY I think we should validate the results of this query. Maybe check the number of rows returned. Won't this test work with/without this change? -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7091 Change subject: IMPALA-5438: Always eval union const exprs in subplan. .. IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were only evaluated for the first fragment instance. However, for a union inside a subplan, we should always evaluate the constant exprs. Testing: - Added a regression test. - Locally ran test_nested_types.py and the union tests in test_queries.py Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 --- M be/src/exec/union-node.cc M be/src/exec/union-node.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test 3 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7091/1 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm
