Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #12193: URL: https://github.com/apache/iotdb/pull/12193#issuecomment-2011828369 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

[PR] Pipe: Introduced aggregate processor as the universal aggregation framework [iotdb]

2024-03-21 Thread via GitHub
Caideyipi opened a new pull request, #12210: URL: https://github.com/apache/iotdb/pull/12210 ## Description This PR introduced aggregate processor and filled in some operators and tumbling windowing tactics. This processor can dynamically adopt windowing processor and operator

[PR] Colin config snapshot parser [iotdb]

2024-03-21 Thread via GitHub
shuolinl opened a new pull request, #12211: URL: https://github.com/apache/iotdb/pull/12211 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
HTHou commented on code in PR #12193: URL: https://github.com/apache/iotdb/pull/12193#discussion_r1533647464 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java: ## @@ -237,8 +237,7 @@ protected void doAddNode() { /** Prepare cluster IoTDB-DataNode

Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #12193: URL: https://github.com/apache/iotdb/pull/12193#issuecomment-2011945320 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Refactor Procedure framework [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12202: URL: https://github.com/apache/iotdb/pull/12202#discussion_r1533442997 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/ProcedureInfo.java: ## @@ -21,79 +21,249 @@ import

Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
HTHou commented on code in PR #12193: URL: https://github.com/apache/iotdb/pull/12193#discussion_r1533563384 ## iotdb-core/tsfile/src/main/java/org/apache/iotdb/tsfile/utils/TsFileUtils.java: ## @@ -55,4 +55,9 @@ public static boolean isSequence(File tsFile) { File folder

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1533430325 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/service/StatisticsService.java: ## @@ -279,17 +279,21 @@ private void

Re: [PR] [IOTDB-6301] Optimize insert first for single replica [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum merged PR #12209: URL: https://github.com/apache/iotdb/pull/12209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix the wrong form of table [iotdb-docs]

2024-03-21 Thread via GitHub
HTHou merged PR #194: URL: https://github.com/apache/iotdb-docs/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Replace string device id with interface IDeviceID [iotdb]

2024-03-21 Thread via GitHub
JackieTien97 merged PR #12177: URL: https://github.com/apache/iotdb/pull/12177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1533693248 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java: ## @@ -69,8 +80,16 @@ public class

Re: [PR] Pipe: Introduced aggregate processor as the universal aggregation framework [iotdb]

2024-03-21 Thread via GitHub
SteveYurongSu commented on code in PR #12210: URL: https://github.com/apache/iotdb/pull/12210#discussion_r1533534050 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/plugin/builtin/BuiltinPipePlugin.java: ## @@ -56,6 +59,11 @@ public enum BuiltinPipePlugin

Re: [PR] [To region_migration] IoTConsensus Interface idempotence [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum closed pull request #12139: [To region_migration] IoTConsensus Interface idempotence URL: https://github.com/apache/iotdb/pull/12139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1533699684 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RegionMigrateService.java: ## @@ -139,6 +168,34 @@ public synchronized boolean

[PR] Pipe: avoid executing too many PipeMetaSyncProcedure after system reboot [iotdb]

2024-03-21 Thread via GitHub
SteveYurongSu opened a new pull request, #12213: URL: https://github.com/apache/iotdb/pull/12213 As title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Bump org.springframework:spring-web from 5.3.30 to 5.3.33 [iotdb]

2024-03-21 Thread via GitHub
HTHou merged PR #12084: URL: https://github.com/apache/iotdb/pull/12084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1533429359 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -535,125 +537,136 @@ public boolean

Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12193: URL: https://github.com/apache/iotdb/pull/12193#discussion_r1533642048 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java: ## @@ -237,8 +237,7 @@ protected void doAddNode() { /** Prepare cluster

Re: [PR] Refactor Procedure framework [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #12202: URL: https://github.com/apache/iotdb/pull/12202#discussion_r1533625247 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/ProcedureInfo.java: ## @@ -105,23 +107,29 @@ public List> oldLoad() { }

Re: [PR] Pipe: avoid executing too many PipeMetaSyncProcedure after system reboot [iotdb]

2024-03-21 Thread via GitHub
SteveYurongSu merged PR #12213: URL: https://github.com/apache/iotdb/pull/12213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe: avoid executing too many PipeMetaSyncProcedure after system reboot [iotdb]

2024-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #12213: URL: https://github.com/apache/iotdb/pull/12213#issuecomment-2012024394 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Pipe: avoid executing too many PipeMetaSyncProcedure after system reboot [iotdb]

2024-03-21 Thread via GitHub
sonarcloud[bot] commented on PR #12213: URL: https://github.com/apache/iotdb/pull/12213#issuecomment-2012043226 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

[PR] Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1 [iotdb]

2024-03-21 Thread via GitHub
dependabot[bot] opened a new pull request, #12214: URL: https://github.com/apache/iotdb/pull/12214 Bumps org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1. [![Dependabot compatibility

Re: [PR] Refactor Procedure recover framework [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum merged PR #12202: URL: https://github.com/apache/iotdb/pull/12202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1534980790 ## integration-test/src/main/java/org/apache/iotdb/it/env/cluster/env/AbstractEnv.java: ## @@ -1007,4 +1009,22 @@ public String getToolsPath() { public String

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1534991736 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/DataNodeKillPoints.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1534991736 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/DataNodeKillPoints.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software

[PR] Fix concurrent load and compaction [iotdb]

2024-03-21 Thread via GitHub
shuwenwei opened a new pull request, #12215: URL: https://github.com/apache/iotdb/pull/12215 ## Description Fix concurrent load and compaction. If a TsFileResource is added in TsFileManager first, then compaction module can get this resource through TsFileManager. However, at this

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1534990599 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -535,125 +537,136 @@ public boolean

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535026292 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/RootProcedureStack.java: ## @@ -74,6 +74,7 @@ protected synchronized void

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535038134 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/ConfigNodeProcedureEnv.java: ## @@ -207,15 +207,18 @@ public boolean

Re: [PR] Remove isClusterMode configuration [iotdb]

2024-03-21 Thread via GitHub
OneSizeFitsQuorum merged PR #12193: URL: https://github.com/apache/iotdb/pull/12193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1 [iotdb]

2024-03-21 Thread via GitHub
HTHou merged PR #12214: URL: https://github.com/apache/iotdb/pull/12214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535005566 ## iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -635,22 +623,68 @@ public void recoverConfiguration() {

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535005469 ## iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java: ## @@ -635,22 +623,68 @@ public void recoverConfiguration() {

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535036692 ## iotdb-protocol/thrift-commons/src/main/thrift/common.thrift: ## @@ -90,12 +90,28 @@ struct TDataNodeConfiguration { 2: required TNodeResource resource }

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1535039756 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/RegionMigrateProcedure.java: ## @@ -234,8 +213,10 @@ public void

Re: [PR] Region migration improvement [iotdb]

2024-03-21 Thread via GitHub
liyuheng5 commented on code in PR #12165: URL: https://github.com/apache/iotdb/pull/12165#discussion_r1534982777 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/AddRegionPeerProcedure.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to

[PR] Pipe: filtered empty tsFiles which should not be parsed or reported [iotdb]

2024-03-21 Thread via GitHub
Caideyipi opened a new pull request, #12216: URL: https://github.com/apache/iotdb/pull/12216 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [