[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 1: (28 comments) http://gerrit.cloudera.org:8080/#/c/7599/1//COMMIT_MSG Commit

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

2017-08-07 Thread Sandish Kumar HN (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7421 to look at the new patch set (#7). Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro)

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7613 to look at the new patch set (#2). Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 11: Verified+1 unrelated flake in raft_consensus-itest (TSAN build only) -- To view, visit

[kudu-CR] consensus: Don't replay config changes

2017-08-07 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/7614 Change subject: consensus: Don't replay config changes .. consensus: Don't replay config changes We have invariants in place that make it

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#4). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7613 to review the following change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

[kudu-CR](branch-1.3.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks This fixes a

[kudu-CR](branch-1.4.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 1: Verified+1 Failure was a flake that has since been fixed -- To view, visit

[kudu-CR](branch-1.4.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks This fixes a

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#11). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++

[kudu-CR] [build-support] added IWYU filter script

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7604 to look at the new patch set (#2). Change subject: [build-support] added IWYU filter script .. [build-support]

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7593 to look at the new patch set (#3). Change subject: [thirdparty]: added include-what-you-use .. [thirdparty]: added

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#3). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] Add NO NVM SUPPORT cmake var to suppress linking or compiling with nvm support

2017-08-07 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5712 To unsubscribe,

[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache

2017-08-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7607/1//COMMIT_MSG Commit Message: Line

[kudu-CR] Add Maintenance Manager visualizer

2017-08-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7570 to look at the new patch set (#7). Change subject: Add Maintenance Manager visualizer .. Add Maintenance Manager

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 7: (1 comment)

[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache

2017-08-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7607 to look at the new patch set (#2). Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Web

[kudu-CR](branch-1.4.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7611

[kudu-CR](branch-1.3.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7612

[kudu-CR](branch-1.3.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7612 Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks This fixes a

[kudu-CR](branch-1.4.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7611 Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. KUDU-2085. Fix crash when seeking past end of

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7545 To

[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache

2017-08-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7607/1//COMMIT_MSG Commit

[kudu-CR] WIP: KUDU-2083. Decrement running maintenance ops on failed prepare

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-2083. Decrement running maintenance ops on failed prepare .. Patch Set 1: looks good but agreed a test woudl be nice -- To view, visit

[kudu-CR] WIP: KUDU-2083. Decrement running maintenance ops on failed prepare

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: KUDU-2083. Decrement running maintenance ops on failed prepare .. WIP: KUDU-2083. Decrement running maintenance ops on failed prepare There is

[kudu-CR] WIP: KUDU-2083. Decrement running maitenance ops on failed prepare

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/7610 Change subject: WIP: KUDU-2083. Decrement running maitenance ops on failed prepare .. WIP: KUDU-2083. Decrement running

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7602/1/src/kudu/fs/data_dirs.cc File

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#2). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] kudu client tools for hadoop and spark import/export(csv,parquet,avro)

2017-08-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: kudu client tools for hadoop and spark import/export(csv,parquet,avro) .. Patch Set 6: (4 comments)

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7545

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Hello Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7545 to look at the new patch set (#3). Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

[kudu-CR] Web UI: switch /maintenance-manager endpoint to mustache

2017-08-07 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7607 to review the following change. Change subject: Web UI: switch /maintenance-manager endpoint to mustache

[kudu-CR] [tests] fix compilation warning on OS X

2017-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [tests] fix compilation warning on OS X .. [tests] fix compilation warning on OS X Fixed compilation warning on OS X due to unused function:

[kudu-CR] [tests] fix compilation warning on OS X

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [tests] fix compilation warning on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7594 To unsubscribe, visit

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR] disk failure: reassign failed tablets

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: disk failure: reassign failed tablets .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR] [build-support] added IWYU filter script

2017-08-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7604 Change subject: [build-support] added IWYU filter script .. [build-support] added IWYU filter script Added a script to filter the

[kudu-CR] WIP [thirdparty]: added include-what-you-use

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7593 to look at the new patch set (#2). Change subject: WIP [thirdparty]: added include-what-you-use .. WIP

[kudu-CR] disk failure: add persistent disk states

2017-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#7). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] disk failure: release failed txs from tracker

2017-08-07 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#6). Change subject: disk failure: release failed txs from tracker .. disk failure:

[kudu-CR] Kudu-2060: Show primary keys in the master's table web UI page

2017-08-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Kudu-2060: Show primary keys in the master's table web UI page .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7569/1//COMMIT_MSG

[kudu-CR] WIP: [iwyu] first pass

2017-08-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#10). Change subject: WIP: [iwyu] first pass .. WIP: [iwyu] first pass Updated C++