[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16527 to look at the new patch set (#7). Change subject: KUDU-2612: initial implementation of TxnManager

[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16527 to look at the new patch set (#6). Change subject: KUDU-2612: initial implementation of TxnManager

[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16527 ) Change subject: KUDU-2612: initial implementation of TxnManager .. Patch Set 5: (9 comments)

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. KUDU-3195: flush when any DMS

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 ) Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. Patch Set 1: (17 comments)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 6: Code-Review+2 (1

[kudu-CR] [partitioning] KUDU-2671: Support for range specific HashSchemas.

2020-10-13 Thread Mahesh Reddy (Code Review)
Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16596 Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. .. [partitioning] KUDU-2671: Support for range

[kudu-CR] KUDU-2612: add TxnManager::BeginTransaction()

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16586 ) Change subject: KUDU-2612: add TxnManager::BeginTransaction() .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2612: add TxnManager::BeginTransaction()

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16586 ) Change subject: KUDU-2612: add TxnManager::BeginTransaction() .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 6: (14 comments)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16581 to look at the new patch set (#6). Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold

[kudu-CR] KUDU-2612: add TxnManager::BeginTransaction()

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16586 ) Change subject: KUDU-2612: add TxnManager::BeginTransaction() .. Patch Set 2: Code-Review+1 (6 comments) Overall LGTM. Just some nits

[kudu-CR] KUDU-3202: [build] Add Spark 3 Support

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16582 ) Change subject: KUDU-3202: [build] Add Spark 3 Support .. KUDU-3202: [build] Add Spark 3 Support This patch adds Sparks 3

[kudu-CR] [Java] Upgrade dependencies

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16583 ) Change subject: [Java] Upgrade dependencies .. [Java] Upgrade dependencies Upgrades the Java dependencies and Gradle versions.

[kudu-CR] KUDU-3202: [build] Add Spark 3 Support

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16582 ) Change subject: KUDU-3202: [build] Add Spark 3 Support .. Patch Set 3: (1 comment)

[kudu-CR] [subprocess] Avoid transitive log4j dependencies

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16592 ) Change subject: [subprocess] Avoid transitive log4j dependencies .. [subprocess] Avoid transitive log4j dependencies This patch

[kudu-CR] KUDU-3202: [build] Add Spark 3 Support

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16582 ) Change subject: KUDU-3202: [build] Add Spark 3 Support .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [Java] Upgrade dependencies

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16583 ) Change subject: [Java] Upgrade dependencies .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16583 To

[kudu-CR] [subprocess] Avoid transitive log4j dependencies

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16592 ) Change subject: [subprocess] Avoid transitive log4j dependencies .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16527 ) Change subject: KUDU-2612: initial implementation of TxnManager .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16527 ) Change subject: KUDU-2612: initial implementation of TxnManager .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 5: (12 comments) Just did

[kudu-CR] KUDU-2612: initial implementation of TxnManager

2020-10-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16527 ) Change subject: KUDU-2612: initial implementation of TxnManager .. Patch Set 5: (6 comments)

[kudu-CR] [subprocess] Avoid transitive log4j dependencies

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16592 Change subject: [subprocess] Avoid transitive log4j dependencies .. [subprocess] Avoid transitive log4j dependencies This patch excludes

[kudu-CR] wip KUDU-3149: don't block op registration on MM mutex

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16580 ) Change subject: wip KUDU-3149: don't block op registration on MM mutex .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 5: Code-Review+1 -- To

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16581 to look at the new patch set (#5). Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold

[kudu-CR] wip KUDU-3149: don't block op registration on MM mutex

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16580 ) Change subject: wip KUDU-3149: don't block op registration on MM mutex .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16581 ) Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold .. Patch Set 4: Code-Review+1 -- To

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 ) Change subject: [client] robust handling of absent master address(es) .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 ) Change subject: [client] robust handling of absent master address(es) .. Patch Set 2: Thank you for fast review, Grant! -- To view,

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16589 ) Change subject: [client] robust handling of absent master address(es) .. [client] robust handling of absent master address(es)

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [client] robust handling of absent master address(es) .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16589 To

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 ) Change subject: [client] robust handling of absent master address(es) .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [Java] Upgrade dependencies

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16583 ) Change subject: [Java] Upgrade dependencies .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16583 To

[kudu-CR] [Java] Upgrade dependencies

2020-10-13 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [Java] Upgrade dependencies .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16583 To unsubscribe, visit

[kudu-CR] KUDU-3202: [build] Add Spark 3 Support

2020-10-13 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16582 to look at the new patch set (#3). Change subject: KUDU-3202: [build] Add Spark 3 Support ..

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16581 to look at the new patch set (#4). Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold

[kudu-CR] [client] robust handling of absent master address(es)

2020-10-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16589 Change subject: [client] robust handling of absent master address(es) .. [client] robust handling of absent master address(es) This

[kudu-CR] KUDU-3195: flush when any DMS in the tablet is older than the time threshold

2020-10-13 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16581 to look at the new patch set (#3). Change subject: KUDU-3195: flush when any DMS in the tablet is older than the time threshold