[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-08 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#5). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Yanlong Zheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 4: (2 comments)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#4). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Yanlong Zheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#3). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: Code-Review+2 I like the version where we don't

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: JD and Dan, do you guys have opinions on this? -- To

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-29 Thread YanlongZheng (Code Review)
YanlongZheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-29 Thread YanlongZheng (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#2). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 1: (2 comments) please add a unit test for this as well

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has uploaded a new change for review. http://gerrit.cloudera.org:8080/5237 Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. KUDU-1757: fix

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has abandoned this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Abandoned RowKeyStringify format check failed -- To view, visit

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has uploaded a new change for review. http://gerrit.cloudera.org:8080/5236 Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. KUDU-1757: fix

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has abandoned this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Abandoned There is a typo in this change. My test environment and git are

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has abandoned this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Abandoned There is a typo in this change. My test environment and git are

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has uploaded a new change for review. http://gerrit.cloudera.org:8080/5235 Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. KUDU-1757: fix

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-11-27 Thread YanlongZheng (Code Review)
YanlongZheng has uploaded a new change for review. http://gerrit.cloudera.org:8080/5234 Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. KUDU-1757: fix