[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for java builds error-prone (http://errorpro

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 7: Fixed my accidental rebase back onto the old patch. -- To view

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] java: enable error-prone for java builds

2018-04-26 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 5: Code-Review+1 Looks fine, thanks -- To view, visit http://gerr

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4425/4/java/gra

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4425/3/java/bu

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. java: enable error-prone for jav

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 ) Change subject: java: enable error-prone for java builds .. Patch Set 3: (3 comments) As for error-prone vs spotbugs, I think they are l

[kudu-CR] java: enable error-prone for java builds

2018-04-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4425 to look at the new patch set (#4). Change subject: java: enable error-prone for java builds ...

[kudu-CR] java: enable error-prone for java builds

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: enable error-prone for java builds .. Patch Set 2: > 23:08:57 [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (d

[kudu-CR] java: enable error-prone for java builds

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: enable error-prone for java builds .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.

[kudu-CR] java: enable error-prone for java builds

2017-02-16 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4425 to look at the new patch set (#2). Change subject: java: enable error-prone for java builds ...