[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: ksck: colorize and clean up output .. ksck: colorize and clean up output Dan and I were looking at some ksck output earlier and found it somewhat hard to

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3094/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#4). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: > One thing I noticed is that you have a newline separating tablet output, but > not tables. added > It

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 3: hrm, appears I may have forgotten to commit or something :) trying again in a moment -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4129/2/src/kudu/tools/color.cc File src/kudu/tools/color.cc:

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: It would be really helpful to print the time that TABLET_DATA_COPYING operations started. Not sure if this is

[kudu-CR] ksck: colorize and clean up output

2016-08-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: One thing I noticed is that you have a newline separating tablet output, but not tables. EG: Table

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3084/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4129 to look at the new patch set (#2). Change subject: ksck: colorize and clean up output .. ksck: colorize and clean

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: colorize and clean up output .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3081/ -- To view, visit

[kudu-CR] ksck: colorize and clean up output

2016-08-25 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4129 to review the following change. Change subject: ksck: colorize and clean up output .. ksck: colorize and