[kudu-CR] WIP: KUDU-1097 (patch 5): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#2). Change subject: WIP: KUDU-1097 (patch 5): Implement a bulk config change API

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8643 to look at the new patch set (#2). Change subject: consensus: Rename ChangeConfigType enum constants

[kudu-CR] KUDU-1097 (patch 5): kudu tablet config change move should use 3-4-3

2017-11-27 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8645 to review the following change. Change subject: KUDU-1097 (patch 5): kudu tablet config_change move should use 3-4-3

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. Patch Set 2: Looks good but the

[kudu-CR] KUDU-1097 (patch 5): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#3). Change subject: KUDU-1097 (patch 5): Implement a bulk config change API

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 2: > I agree with the diagnosis and

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. consensus: Rename ChangeConfigType enum constants Since

[kudu-CR] [tests] fix flakes in delete table-itest

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7972 ) Change subject: [tests] fix flakes in delete_table-itest .. Patch Set 3: > Patch Set 3: > > (1 comment) +1 to ASSERT_EVENTUALLY -- To

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8649 to look at the new patch set (#2). Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. consensus: Rename

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 1: Code-Review+1 I agree with the diagnosis

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8649 to look at the new patch set (#3). Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8651 to look at the new patch set (#2). Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival ..

[kudu-CR] KUDU-1097 (patch 5): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#4). Change subject: KUDU-1097 (patch 5): Implement a bulk config change API

[kudu-CR] disk failure: itest for tablet copies

2017-11-27 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8636 to look at the new patch set (#3). Change subject: disk failure: itest for tablet copies ..

[kudu-CR] java: revisit maven shade configuration

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8661 ) Change subject: java: revisit maven shade configuration .. Patch Set 2: I hacked up a script to validate shaded and unshaded dependencies

[kudu-CR] java build: Add script to verify output of generated JARs

2017-11-27 Thread Mike Percy (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8662 to review the following change. Change subject: java build: Add script to verify output of generated JARs .. java

[kudu-CR] java build: Add script to verify output of generated JARs

2017-11-27 Thread Mike Percy (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8662 to look at the new patch set (#2). Change subject: java build: Add script to verify output of generated JARs

[kudu-CR] KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8633 ) Change subject: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. Patch Set 1: (1 comment) Looks good overall, just one small nit.

[kudu-CR] WIP: KUDU-1097 (patch 5): Implement a bulk config change API

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: WIP: KUDU-1097 (patch 5): Implement a bulk config change API .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8633 to look at the new patch set (#6). Change subject: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas

[kudu-CR] KUDU-1097 (patch 3): Implement promotion of NON VOTER replicas

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8633 ) Change subject: KUDU-1097 (patch 3): Implement promotion of NON_VOTER replicas .. KUDU-1097 (patch 3): Implement promotion of

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. Patch Set 3: Code-Review+2 Thanks! -- To view, visit

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8649 Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. [tablet_metadata] protect pre_flush_callback_ by

[kudu-CR] java-client: fix TestScannerMultiTablet

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8655 ) Change subject: java-client: fix TestScannerMultiTablet .. Patch Set 1: Code-Review+2 (1 comment) Just a question. If not, I think this

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API .. Patch Set 6: (6 comments)

[kudu-CR] disk failure: randomized tserver test

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8387 ) Change subject: disk failure: randomized tserver test .. Patch Set 5: Verified+1 This appears to have failed due to KUDU-1736. -- To

[kudu-CR] disk failure: randomized tserver test

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: disk failure: randomized tserver test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8387 To unsubscribe, visit

[kudu-CR] docs: add 1.6 release note for several improvements/fix

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8640 ) Change subject: docs: add 1.6 release note for several improvements/fix .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] docs: add 1.6 release note for several improvements/fix

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8640 ) Change subject: docs: add 1.6 release note for several improvements/fix .. docs: add 1.6 release note for several improvements/fix

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-1097 (patch 5b): kudu tablet config change move should use 3-4-3

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8645 ) Change subject: KUDU-1097 (patch 5b): kudu tablet config_change move should use 3-4-3 .. Patch Set 3: (5 comments)

[kudu-CR] java-client: fix TestScannerMultiTablet

2017-11-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8655 ) Change subject: java-client: fix TestScannerMultiTablet .. Patch Set 1: (1 comment)

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 3: (1 comment)

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [tools] added verbose mode for ksck

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8596 ) Change subject: [tools] added verbose mode for ksck .. [tools] added verbose mode for ksck Introduced verbose mode for the ksck

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#7). Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Andrew Wong (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8651 to look at the new patch set (#3). Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. Patch Set 3: (1 comment)

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [tools] added verbose mode for ksck

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8596 ) Change subject: [tools] added verbose mode for ksck .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8596

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8649 to look at the new patch set (#4). Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 4: (1 comment)

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 3: (1 comment)

[kudu-CR] java build: Add script to verify output of generated JARs

2017-11-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 ) Change subject: java build: Add script to verify output of generated JARs .. Patch Set 3: Should we hook this up to CI? -- To view,

[kudu-CR] java build: Add script to verify output of generated JARs

2017-11-27 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8662 ) Change subject: java build: Add script to verify output of generated JARs .. java build: Add

[kudu-CR] java: revisit maven shade configuration

2017-11-27 Thread Dan Burkert (Code Review)
Hello Mike Percy, Andrew Wong, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8661 to look at the new patch set (#3). Change subject: java: revisit maven shade configuration

[kudu-CR] [consensus queue] update replica health reporting

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8663 to look at the new patch set (#2). Change subject: [consensus_queue] update replica health reporting ..

[kudu-CR] java: revisit maven shade configuration

2017-11-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8661 ) Change subject: java: revisit maven shade configuration .. Patch Set 3: > I hacked up a script to validate shaded and unshaded

[kudu-CR] [consensus queue] definitive

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8663 Change subject: [consensus_queue] definitive .. [consensus_queue] definitive Report the health status of a replica as HEALTHY only if

[kudu-CR] [consensus queue] update replica health reporting

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8663 ) Change subject: [consensus_queue] update replica health reporting .. Patch Set 2: > Build Failed > >

[kudu-CR] KUDU-1097: 'gone-and-back tablet server' test scenario

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8664 Change subject: KUDU-1097: 'gone-and-back tablet server' test scenario .. KUDU-1097: 'gone-and-back tablet server' test scenario Added

[kudu-CR] WIP [consensus queue] update replica health reporting

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8663 to look at the new patch set (#3). Change subject: WIP [consensus_queue] update replica health reporting

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8651 Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. tablet_copy-itest: fix flaky TestMetricsResetAfterRevival

[kudu-CR] exactly once writes-itest for faulty disks

2017-11-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8388 to look at the new patch set (#3). Change subject: exactly_once_writes-itest for faulty disks

[kudu-CR] KUDU-1097 (patch 5b): kudu tablet config change move should use 3-4-3

2017-11-27 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8645 to look at the new patch set (#3). Change subject: KUDU-1097 (patch 5b): kudu tablet config_change move should use 3-4-3

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/7919 ) Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Abandoned superseded by

[kudu-CR] Improve breakpad tooling

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: Improve breakpad tooling .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8576 To unsubscribe, visit

[kudu-CR] Improve breakpad tooling

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8576 ) Change subject: Improve breakpad tooling .. Improve breakpad tooling Kudu has used Google Breakpad to produce minidumps since

[kudu-CR] Improve breakpad tooling

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8576 ) Change subject: Improve breakpad tooling .. Patch Set 4: Verified+1 Code-Review+2 Overriding unrelated failure -- To view, visit

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API .. Patch Set 6: (6 comments)

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 2: > > I agree with the diagnosis and

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#5). Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API

[kudu-CR] java-client: fix TestScannerMultiTablet

2017-11-27 Thread Dan Burkert (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8655 to review the following change. Change subject: java-client: fix TestScannerMultiTablet .. java-client: fix

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API .. Patch Set 6: (1 comment)

[kudu-CR] consensus: Rename ChangeConfigType enum constants

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8643 ) Change subject: consensus: Rename ChangeConfigType enum constants .. Patch Set 1: (1 comment)

[kudu-CR] tablet copy-itest: fix flaky TestMetricsResetAfterRevival

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8651 ) Change subject: tablet_copy-itest: fix flaky TestMetricsResetAfterRevival .. tablet_copy-itest: fix flaky

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8649 to look at the new patch set (#5). Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8644 ) Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API .. Patch Set 8: (2 comments)

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#8). Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 5: Code-Review+1 (1 comment) small nit

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 5: (1 comment)

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. [tablet_metadata] protect pre_flush_callback_

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Removed reviewer Kudu Jenkins with the

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 5: Verified+1 Unrelated flake in

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [tablet metadata] protect pre flush callback by flush lock

2017-11-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8649 ) Change subject: [tablet_metadata] protect pre_flush_callback_ by flush_lock_ .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] java: revisit maven shade configuration

2017-11-27 Thread Dan Burkert (Code Review)
Hello Mike Percy, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8661 to review the following change. Change subject: java: revisit maven shade configuration .. java: revisit

[kudu-CR] KUDU-1097 (patch 5a): Implement a bulk config change API

2017-11-27 Thread Mike Percy (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8644 to look at the new patch set (#9). Change subject: KUDU-1097 (patch 5a): Implement a bulk config change API