[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

[Michael Ho (Code Review)]

Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8700 )

Change subject: [security] Make the kerberos principal configurable for Kudu 
servers
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8700/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:

http://gerrit.cloudera.org:8080/#/c/8700/1/src/kudu/security/init.cc@382
PS1, Line 382: raw_principal
in_principal seems like a better name.



--
To view, visit http://gerrit.cloudera.org:8080/8700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd16b3360d8d2df5a609eb897bb9810e662fc695
Gerrit-Change-Number: 8700
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Fri, 01 Dec 2017 07:08:58 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2230: the leader is always a viable voter

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8709

to look at the new patch set (#4).

Change subject: KUDU-2230: the leader is always a viable voter
..

KUDU-2230: the leader is always a viable voter

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume that the leader is always a viable voter.  Prior to this patch,
the leader itself was not counted as a viable voter since the leader
does not update its own last_communication_time.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
2 files changed, 49 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/4
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-2229. consensus: Leader should not start FD

[Mike Percy (Code Review)]

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8711

to review the following change.


Change subject: KUDU-2229. consensus: Leader should not start FD
..

KUDU-2229. consensus: Leader should not start FD

This patch fixes a log spam issue caused by commit
28a671365d6d38da966481daf937b3776e3d4852 that erroneously enables the
failure detector on the leader when a configuration takes place. That
bug had no consensus safety implications, but it did generate a large
volume of confusing log messages in a neverending loop.

This patch also includes some minor updates to InternalMiniCluster for
convenience purposes.

Change-Id: Ie2ec9c5499e8e4c1659333bd53dd2d7f6dae81f5
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/mini-cluster/internal_mini_cluster.cc
M src/kudu/mini-cluster/internal_mini_cluster.h
M src/kudu/mini-cluster/mini_cluster.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/periodic.h
10 files changed, 199 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/8711/1
--
To view, visit http://gerrit.cloudera.org:8080/8711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2ec9c5499e8e4c1659333bd53dd2d7f6dae81f5
Gerrit-Change-Number: 8711
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 

[kudu-CR] consensus: Make queue more debuggable

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8708 )

Change subject: consensus: Make queue more debuggable
..

consensus: Make queue more debuggable

After the introduction of SafeToEvict() logic in the consensus queue,
the eviction criteria has become more subtle. It would be helpful to get
more information about the state of the leader queue from the web UI to
aid in troubleshooting. This patch dumps the queue information in the
web UI and also includes the time since last communication with each
peer in the per-peer Watermarks table.

Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Reviewed-on: http://gerrit.cloudera.org:8080/8708
Reviewed-by: Andrew Wong 
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] consensus: Make queue more debuggable

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8708 )

Change subject: consensus: Make queue more debuggable
..


Patch Set 2: Code-Review+2

Gotcha


--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:40:28 +
Gerrit-HasComments: No

[kudu-CR] [consensus queue] the leader is always a viable voter

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] the leader is always a viable voter
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:39:17 +
Gerrit-HasComments: No

[kudu-CR] consensus: Make queue more debuggable

[Mike Percy (Code Review)]

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8708

to look at the new patch set (#2).

Change subject: consensus: Make queue more debuggable
..

consensus: Make queue more debuggable

After the introduction of SafeToEvict() logic in the consensus queue,
the eviction criteria has become more subtle. It would be helpful to get
more information about the state of the leader queue from the web UI to
aid in troubleshooting. This patch dumps the queue information in the
web UI and also includes the time since last communication with each
peer in the per-peer Watermarks table.

Change-Id: I052285a6885c251adbbab62410530fef4769fe72
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/8708/2
--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] consensus: Make queue more debuggable

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8708 )

Change subject: consensus: Make queue more debuggable
..


Patch Set 1:

(1 comment)

> Patch Set 1:
>
> (1 comment)
>
> How's the overlap of the queue_state with what's already dumped to html?

the queue state is what gets dumped when you become leader and it's just a 
laundry list of queue items like majority replicated index and stuff like that.

string PeerMessageQueue::QueueState::ToString() const {
  return Substitute("All replicated index: $0, Majority replicated index: $1, "
  "Committed index: $2, Last appended: $3, Last appended by leader: $4, 
Current term: $5, "
  "Majority size: $6, State: $7, Mode: $8$9",
  all_replicated_index, majority_replicated_index,
  committed_index, OpIdToString(last_appended), 
last_idx_appended_to_leader, current_term,
  majority_size_, state, (mode == LEADER ? "LEADER" : "NON_LEADER"),
  active_config ? ", active raft config: " + 
SecureShortDebugString(*active_config) : "");
}

http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc@131
PS1, Line 131: );
> nit: previous line? Or is this stylistic
ah, yeah, mistake. will fix



--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:37:09 +
Gerrit-HasComments: Yes

[kudu-CR] consensus: Make queue more debuggable

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8708 )

Change subject: consensus: Make queue more debuggable
..


Patch Set 1: Code-Review+1

LGTM, maybe just address the stylistic issue, if needed.


--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:35:38 +
Gerrit-HasComments: No

[kudu-CR] [consensus queue] the leader is always a viable voter

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8709

to look at the new patch set (#3).

Change subject: [consensus_queue] the leader is always a viable voter
..

[consensus_queue] the leader is always a viable voter

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume that the leader is always a viable voter.  Prior to this patch,
the leader itself was not counted as a viable voter since the leader
does not update its own last_communication_time.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/3
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [consensus queue] the leader is always a viable voter

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] the leader is always a viable voter
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG@7
PS2, Line 7: healthy
> nit: can you also call it a viable voter here? In case it gets confused wit
Done



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 04:02:36 +
Gerrit-HasComments: Yes

[kudu-CR] [consensus queue] local peer is always healthy

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] local peer is always healthy
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG@7
PS2, Line 7: healthy
nit: can you also call it a viable voter here? In case it gets confused with 
Peer "HealthPB" healthy



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 03:57:35 +
Gerrit-HasComments: Yes

[kudu-CR] [consensus queue] local peer is always healthy

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8709

to look at the new patch set (#2).

Change subject: [consensus_queue] local peer is always healthy
..

[consensus_queue] local peer is always healthy

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume that the leader is always a viable voter.  Prior to this patch,
the leader itself was not counted as a viable voter since the leader
does not update its own last_communication_time.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/2
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [consensus queue] local peer is always healthy

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] local peer is always healthy
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8709/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/1//COMMIT_MSG@12
PS1, Line 12: counter
nit: counted


http://gerrit.cloudera.org:8080/#/c/8709/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/8709/1/src/kudu/consensus/consensus_queue.cc@420
PS1, Line 420: alive
nit: "local"? or: "This is the local peer, which is guaranteed to be viable."



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 03:52:32 +
Gerrit-HasComments: Yes

[kudu-CR] [consensus queue] local peer is always healthy

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8709


Change subject: [consensus_queue] local peer is always healthy
..

[consensus_queue] local peer is always healthy

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume the local peer is always healthy.  Otherwise, since the
last_communication_time is not updated by the leader, the leader itself
is not counter as a viable voter.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/1
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] consensus: Make queue more debuggable

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8708 )

Change subject: consensus: Make queue more debuggable
..


Patch Set 1:

(1 comment)

How's the overlap of the queue_state with what's already dumped to html?

http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/8708/1/src/kudu/consensus/consensus_queue.cc@131
PS1, Line 131: );
nit: previous line? Or is this stylistic



--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 03:26:23 +
Gerrit-HasComments: Yes

[kudu-CR] consensus: Make queue more debuggable

[Mike Percy (Code Review)]

Hello Andrew Wong,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8708

to review the following change.


Change subject: consensus: Make queue more debuggable
..

consensus: Make queue more debuggable

After the introduction of SafeToEvict() logic in the consensus queue,
the eviction criteria has become more subtle. It would be helpful to get
more information about the state of the leader queue from the web UI to
aid in troubleshooting. This patch dumps the queue information in the
web UI and also includes the time since last communication with each
peer in the per-peer Watermarks table.

Change-Id: I052285a6885c251adbbab62410530fef4769fe72
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/8708/1
--
To view, visit http://gerrit.cloudera.org:8080/8708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I052285a6885c251adbbab62410530fef4769fe72
Gerrit-Change-Number: 8708
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8704 
)

Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet
..


Abandoned

It seem this is not what we want.
--
To view, visit http://gerrit.cloudera.org:8080/8704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id9a5cc490370800b9a9ded09cb6a7e923b1933b3
Gerrit-Change-Number: 8704
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

[Alexey Serbin (Code Review)]

Hello Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8704

to look at the new patch set (#2).

Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet
..

[kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

Fixed flake in AdminCliTest.TestMoveTablet_KUDU_1097 test.  The flake
happened because the leader replica changed while waiting for
the specified number of voters/members in the Raft configuration.

Change-Id: Id9a5cc490370800b9a9ded09cb6a7e923b1933b3
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/kudu-admin-test.cc
5 files changed, 62 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/8704/2
--
To view, visit http://gerrit.cloudera.org:8080/8704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9a5cc490370800b9a9ded09cb6a7e923b1933b3
Gerrit-Change-Number: 8704
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [known issues] incompatibility note for bouncycastle <= 1.52

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8706


Change subject: [known_issues] incompatibility note for bouncycastle <= 1.52
..

[known_issues] incompatibility note for bouncycastle <= 1.52

Added a note on incompatibility of server certificates generated by Kudu
IPKI with bouncycastle version 1.52 and prior.

Change-Id: I7b5627ec640edc4b6185f5088c5f64f01b981776
---
M docs/known_issues.adoc
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/8706/1
--
To view, visit http://gerrit.cloudera.org:8080/8706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b5627ec640edc4b6185f5088c5f64f01b981776
Gerrit-Change-Number: 8706
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] release notes: a couple micro-updates

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8705


Change subject: release notes: a couple micro-updates
..

release notes: a couple micro-updates

Change-Id: I0ac836c512e7316a4f3fd71446c34005d5a48964
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/8705/1
--
To view, visit http://gerrit.cloudera.org:8080/8705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ac836c512e7316a4f3fd71446c34005d5a48964
Gerrit-Change-Number: 8705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

[Dan Burkert (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8703

to look at the new patch set (#3).

Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0
..

release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
---
M docs/release_notes.adoc
1 file changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/8703/3
--
To view, visit http://gerrit.cloudera.org:8080/8703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
Gerrit-Change-Number: 8703
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR](branch-1.5.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8699 )

Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/8699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa9241dea1304076ed5cfaec78779d15b11293ff
Gerrit-Change-Number: 8699
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 30 Nov 2017 22:57:29 +
Gerrit-HasComments: No

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

[Dan Burkert (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8703

to look at the new patch set (#2).

Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0
..

release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
---
M docs/release_notes.adoc
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/8703/2
--
To view, visit http://gerrit.cloudera.org:8080/8703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
Gerrit-Change-Number: 8703
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8704


Change subject: [kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet
..

[kudu-admin-test] fix flake in AdminCliTest.TestMoveTablet

Fixed flake in AdminCliTest.TestMoveTablet_KUDU_1097 test.  The flake
happened because the leader replica changed while waiting for
the specified number of voters/members in the Raft configuration.

Change-Id: Id9a5cc490370800b9a9ded09cb6a7e923b1933b3
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/ts_itest-base.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/kudu-admin-test.cc
5 files changed, 65 insertions(+), 27 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/8704/1
--
To view, visit http://gerrit.cloudera.org:8080/8704
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9a5cc490370800b9a9ded09cb6a7e923b1933b3
Gerrit-Change-Number: 8704
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 

[kudu-CR] release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

[Dan Burkert (Code Review)]

Hello Mike Percy,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8703

to review the following change.


Change subject: release notes: add KUDU-2190 and KUDU-2173 for 1.6.0
..

release notes: add KUDU-2190 and KUDU-2173 for 1.6.0

Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
---
M docs/release_notes.adoc
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/8703/1
--
To view, visit http://gerrit.cloudera.org:8080/8703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5b01a77b07073f529f31e5a9fb06af9afa113be
Gerrit-Change-Number: 8703
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] A couple of 1.6 release notes

[Will Berkeley (Code Review)]

Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8702


Change subject: A couple of 1.6 release notes
..

A couple of 1.6 release notes

Change-Id: Ia69cc1904b5e1a81fecf20a2ca5a8fb1908a6025
---
M docs/release_notes.adoc
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/8702/1
--
To view, visit http://gerrit.cloudera.org:8080/8702
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia69cc1904b5e1a81fecf20a2ca5a8fb1908a6025
Gerrit-Change-Number: 8702
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 

[kudu-CR] [security] Make the kerberos principal configurable for Kudu servers

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8700


Change subject: [security] Make the kerberos principal configurable for Kudu 
servers
..

[security] Make the kerberos principal configurable for Kudu servers

The Kudu security library currently sources the kerberos principal
directly from FLAGS_principal. Since this is a library, we'd rather
move this to be an option that is passed through InitKerberosForServer().
Users of the sercurity library may pass any principal that they want
to.

Testing: All current tests pass. Since this is a minor refactor, no new
tests are needed.

Change-Id: Idd16b3360d8d2df5a609eb897bb9810e662fc695
---
M src/kudu/security/init.cc
M src/kudu/security/init.h
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/server/server_base.cc
4 files changed, 29 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/8700/1
--
To view, visit http://gerrit.cloudera.org:8080/8700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd16b3360d8d2df5a609eb897bb9810e662fc695
Gerrit-Change-Number: 8700
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 

[kudu-CR](branch-1.5.x) KUDU-2209. HybridClock doesn't handle changes in STA NANO flag

[Attila Bukor (Code Review)]

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8699

to review the following change.


Change subject: KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag
..

KUDU-2209. HybridClock doesn't handle changes in STA_NANO flag

Users have occasionally reported spurious crashes due to Kudu thinking
that another node has a time stamp from the future. After some debugging
I realized that the issue is that we currently capture the flag
'STA_NANO' from the kernel only at startup. This flag indicates whether
the kernel's sub-second timestamp is in nanoseconds or microseconds. We
initially assumed this was a static property of the kernel. However it
turns out that this flag can get toggled at runtime by ntp in certain
circumstances. Given this, it was possible for us to interpret a number
of nanoseconds as if it were microseconds, resulting in a timestamp up
to 1000 seconds in the future.

This patch changes the SystemNtp time source to always use the 'adjtime'
call to fetch the clock, and looks at the STA_NANO flag on every such
call rather than only at startup.

I checked the source for the ntp_gettime call that we used to use, and
it turns out it was implemented in terms of the same adjtime() call, so
there should be no performance penalty in this change.

This patch doesn't include tests since it's based on some kernel
functionality. However, I was able to test it as follows:

- wrote a simple program to print the time once a second
- stopped ntp, ran chrony, stopped chrony, and started ntpd
-- this has the side effect of clearing STA_NANO
- waited 10 minutes or so, and eventually ntp reset back to STA_NANO
-- this caused my test program to start printing incorrect timestamps
   as it was interpreting nanosecond values from the kernel as if they
   were microseconds

Change-Id: Iaa9241dea1304076ed5cfaec78779d15b11293ff
Reviewed-on: http://gerrit.cloudera.org:8080/8450
Reviewed-by: Alexey Serbin 
Tested-by: Alexey Serbin 
---
M src/kudu/clock/system_ntp.cc
M src/kudu/clock/system_ntp.h
2 files changed, 21 insertions(+), 53 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/8699/1
--
To view, visit http://gerrit.cloudera.org:8080/8699
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9241dea1304076ed5cfaec78779d15b11293ff
Gerrit-Change-Number: 8699
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

> OK. But looking at test logs more, it doesn't actually distinguish between 
> voting while copying vs running while tombstoned, since if a server restarts 
> with a tombstoned tablet its consensus state will be "Initializing" just like 
> a copying tablet's, so maybe it's not so useful.

Ah, of course you're right. But wouldn't my suggested change still work in that 
case?


--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 21:02:41 +
Gerrit-HasComments: No

[kudu-CR] Add initial internal INT128/ int128 support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8533 )

Change subject: Add initial internal INT128/__int128 support
..


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h
File src/kudu/util/int128.h:

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h@43
PS15, Line 43:   std::ostream& operator<<(std::ostream& os, const __int128& 
val);
> I only defined int128_t within the Kudu namespace to avoid any issues.
ah ok, SGTM.



--
To view, visit http://gerrit.cloudera.org:8080/8533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1
Gerrit-Change-Number: 8533
Gerrit-PatchSet: 15
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 30 Nov 2017 18:43:18 +
Gerrit-HasComments: Yes

[kudu-CR] Add initial internal INT128/ int128 support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8533 )

Change subject: Add initial internal INT128/__int128 support
..


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h
File src/kudu/util/int128.h:

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h@43
PS15, Line 43:   std::ostream& operator<<(std::ostream& os, const __int128& 
val);
> You might consider defining this with int128_t instead of __int128, but fee
I only defined int128_t within the Kudu namespace to avoid any issues.

Everywhere else I used __int128. If I use int128_t here it causes issues in 
some of the gutil code.



--
To view, visit http://gerrit.cloudera.org:8080/8533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1
Gerrit-Change-Number: 8533
Gerrit-PatchSet: 15
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 30 Nov 2017 18:41:05 +
Gerrit-HasComments: Yes

[kudu-CR] Add initial internal INT128/ int128 support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8533 )

Change subject: Add initial internal INT128/__int128 support
..


Patch Set 15:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128-test.cc
File src/kudu/util/int128-test.cc:

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128-test.cc@20
PS15, Line 20: #include 
use  to be consistent with the  already here.  Pretty sure 
IWYU allows either.


http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h
File src/kudu/util/int128.h:

http://gerrit.cloudera.org:8080/#/c/8533/15/src/kudu/util/int128.h@43
PS15, Line 43:   std::ostream& operator<<(std::ostream& os, const __int128& 
val);
You might consider defining this with int128_t instead of __int128, but feel 
free to ignore if there's a good reason not to.



--
To view, visit http://gerrit.cloudera.org:8080/8533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1
Gerrit-Change-Number: 8533
Gerrit-PatchSet: 15
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 30 Nov 2017 18:37:40 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2191: bump Hive package

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8691 )

Change subject: KUDU-2191: bump Hive package
..

KUDU-2191: bump Hive package

Bumps the packaged Hive version in order to fix a logging bug
(HIVE-16939). Also strips a few more unnecessary jars, and switches to
console logging for the mini HMS.

Change-Id: I4ba17eb76761b2977cd8f643eebb87bcec49034e
Reviewed-on: http://gerrit.cloudera.org:8080/8691
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M src/kudu/hms/mini_hms.cc
M thirdparty/package-hive.sh
M thirdparty/vars.sh
3 files changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ba17eb76761b2977cd8f643eebb87bcec49034e
Gerrit-Change-Number: 8691
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2191: bump Hive package

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8691 )

Change subject: KUDU-2191: bump Hive package
..


Patch Set 1: Code-Review+2

I don't have a ton of context here, but the change looks small and straight 
forward


--
To view, visit http://gerrit.cloudera.org:8080/8691
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ba17eb76761b2977cd8f643eebb87bcec49034e
Gerrit-Change-Number: 8691
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 30 Nov 2017 17:46:54 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[Dan Burkert (Code Review)]

Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8692

to look at the new patch set (#2).

Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client
..

KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

The bulk of this commit is adding a new Thrift transport type,
SaslClientTransport, which facilitates SASL GSSAPI negotiation, as well
as integrity/privacy channel protection. The new transport is based on
Impala's version with some significant changes:

- Impala has a client and server SASL transport, necessitating a common
  superclass (SaslTransport). Since we only need a client transport, I
  collapsed all of the logic into a single class, which I think makes the
  code easier to follow.
- The transport uses Kudu helper types where possible, e.g., faststring
  buffers, and our existing SASL utility infrastructure.
- Integrity and privacy channel protection are implemented.

There are no standlone unit-tests for the transport, since that would
require implementing the server-specific counterpart. Instead, the class
is tested indirectly through using the HMS client to communicate with a
Kerberos-enabled HMS instance.

Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
A src/kudu/hms/sasl_client_transport.cc
A src/kudu/hms/sasl_client_transport.h
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
14 files changed, 822 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8692/2
--
To view, visit http://gerrit.cloudera.org:8080/8692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345
Gerrit-Change-Number: 8692
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling

[Dan Burkert (Code Review)]

Hello Tidy Bot, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8494

to look at the new patch set (#5).

Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling
..

KUDU-2191 (4/n): HMS Thrift client fault handling

This commit improves the new HMS Thrift client's ability to handle
faults. In particular:

- The client now uses send, receive, and connect timeouts so that a
  non-responsive HMS instance will not block the client indefinitely.
- The Thrift logging callback is hooked up to glog so that we get proper
  log messages from Thrift.
- The HmsClient class and method docs include information about behavior
  when errors are encountered.

In the part 2 review, Todd also brought up the prospect of creating a
wrapper Thrift socket or transport to inject slow log warning messages
automatically. I've held off doing this for now, because I haven't been
able to figure out a way to do that which can associate the slowness
with higher-level operations like 'create database', as opposed to
lower-level like 'socket write'. I've made sure to apply the slow
warning calls uniformly across the HmsClient methods, and I don't think
it will be too onerous to keep them consistent in the future.

Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d
---
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
5 files changed, 178 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/8494/5
--
To view, visit http://gerrit.cloudera.org:8080/8494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d
Gerrit-Change-Number: 8494
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [KUDU-2214] Voting while tablet copying says "voting while tombstoned"

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8666 )

Change subject: [KUDU-2214] Voting while tablet copying says "voting while 
tombstoned"
..


Patch Set 1:

> (1 comment)

OK. But looking at test logs more, it doesn't actually distinguish between 
voting while copying vs running while tombstoned, since if a server restarts 
with a tombstoned tablet its consensus state will be "Initializing" just like a 
copying tablet's, so maybe it's not so useful.


--
To view, visit http://gerrit.cloudera.org:8080/8666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id604bc6122c4291a27fe4c8543408b5be382742c
Gerrit-Change-Number: 8666
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 30 Nov 2017 17:15:47 +
Gerrit-HasComments: No