[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-07-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..


Patch Set 1: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2670/

-- 
To view, visit http://gerrit.cloudera.org:8080/3738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] Add docs for non-covering range partitioning

2016-07-27 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3796

Change subject: Add docs for non-covering range partitioning
..

Add docs for non-covering range partitioning

Change-Id: I3b0fd7500c5399db9dcad617ae67fea247307353
---
M docs/kudu_impala_integration.adoc
M docs/schema_design.adoc
2 files changed, 227 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/3796/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b0fd7500c5399db9dcad617ae67fea247307353
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones 


[kudu-CR] Add docs for non-covering range partitioning

2016-07-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: Add docs for non-covering range partitioning
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2669/

-- 
To view, visit http://gerrit.cloudera.org:8080/3796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0fd7500c5399db9dcad617ae67fea247307353
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-07-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [java-client] repackage to org.apache.kudu (Part 3)
..


Patch Set 1: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2668/

-- 
To view, visit http://gerrit.cloudera.org:8080/3738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b6d19946e712e1e424ff28bd7b56d5419fd0982
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2667/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: No


[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-27 Thread song bruce zhang (Code Review)
song bruce zhang has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3787/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java:

Line 88: } catch (com.stumbleupon.async.TimeoutException e) {
> Wouldn't it be better to just check if the RPC has timed out?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: Yes


[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2666/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] KUDU-1542: in some cases apply will hang.

2016-07-27 Thread song bruce zhang (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3787

to look at the new patch set (#3).

Change subject: KUDU-1542: in some cases apply will hang.
..

KUDU-1542: in some cases apply will hang.

In current implementation, apply will retry
forever when met failed. It would be better to
have some limit to notify caller.

Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/3787/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins