[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error .. Patch Set 5: (7 comments) this would need appropriate tests before it can be committed http://

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: It seems like in the context of a projection, we don't want t

[kudu-CR] docs: add notes for multi master migration

2017-01-17 Thread zhen.zhang (Code Review)
zhen.zhang has uploaded a new change for review. http://gerrit.cloudera.org:8080/5728 Change subject: docs: add notes for multi master migration .. docs: add notes for multi master migration Change-Id: I7e469bc23b650f3b99c785

[kudu-CR] WIP: Add a tool to purge UNDOs, and one to summarize data size

2017-01-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: Add a tool to purge UNDOs, and one to summarize data size .. Patch Set 1: (6 comments) Here's your *it probably won't eat your data* seal of approval. http:/

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2017-01-17 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 7: (6 comments) TFTR Mike, I will be adding one more test which changes ju

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2017-01-17 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5111 to look at the new patch set (#8). Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .

[kudu-CR] WIP: Add a tool to purge UNDOs, and one to summarize data size

2017-01-17 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5727 to review the following change. Change subject: WIP: Add a tool to purge UNDOs, and one to summarize data size .

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has posted comments on this change. Change subject: KUDU-1673 [java client] more informative kudu-spark write error .. Patch Set 5: thanks jenkins <3 -- To view, visit http://gerrit.cloudera.org:8080/5725 To unsu

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-17 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5725 to look at the new patch set (#5). Change subject: KUDU-1673 [java client] more informative kudu-spark write error .

[kudu-CR] [TLS certs management] initial commit

2017-01-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [TLS certs management] initial commit .. Patch Set 1: (33 comments) Thank you for the review. I'll post a new version soon. http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-17 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5725 to look at the new patch set (#4). Change subject: KUDU-1673 [java client] more informative kudu-spark write error .

[kudu-CR] KUDU-1673 [java client] more informative kudu-spark write error

2017-01-17 Thread eric-maynard (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5725 to look at the new patch set (#3). Change subject: KUDU-1673 [java client] more informative kudu-spark write error .

[kudu-CR] Added support for WriteException

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has abandoned this change. Change subject: Added support for WriteException .. Abandoned Rolled into https://gerrit.cloudera.org/#/c/5725/ -- To view, visit http://gerrit.cloudera.org:8080/5725 To unsubscribe, vi

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 1: Code-Review-2 I'm pretty sure we don't want this limit

[kudu-CR] Added support for WriteException

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has restored this change. Change subject: Added support for WriteException .. Restored -- To view, visit http://gerrit.cloudera.org:8080/5725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-

[kudu-CR] Added support for WriteException

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has abandoned this change. Change subject: Added support for WriteException .. Abandoned Rolled into https://gerrit.cloudera.org/#/c/5725/ -- To view, visit http://gerrit.cloudera.org:8080/5724 To unsubscribe, vi

[kudu-CR] Added support for WriteException

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has uploaded a new patch set (#2). Change subject: Added support for WriteException .. Added support for WriteException Change-Id: I935b5d1c61a8430ec48b90071374160505224c69 Initial commit Change-Id: I663dddbf1b01f

[kudu-CR] Initial commit

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has uploaded a new change for review. http://gerrit.cloudera.org:8080/5725 Change subject: Initial commit .. Initial commit Change-Id: I663dddbf1b01f9c3d90f92dd484fc1a0018243c5 --- A java/kudu-client/src/main/jav

[kudu-CR] Added support for WriteException

2017-01-17 Thread eric-maynard (Code Review)
eric-maynard has uploaded a new change for review. http://gerrit.cloudera.org:8080/5724 Change subject: Added support for WriteException .. Added support for WriteException Change-Id: I935b5d1c61a8430ec48b90071374160505224c69