[kudu-CR] KUDU-1097: more robust criteria for replica eviction

[Alexey Serbin (Code Review)]

Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/8679 )

Change subject: KUDU-1097: more robust criteria for replica eviction
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
Gerrit-Change-Number: 8679
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1097: more robust criteria for replica eviction

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8679 )

Change subject: KUDU-1097: more robust criteria for replica eviction
..


Patch Set 6: Verified+1

unrelated flake in tablet_copy-itest


--
To view, visit http://gerrit.cloudera.org:8080/8679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
Gerrit-Change-Number: 8679
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 08 Dec 2017 06:44:25 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) Updating web site for Kudu 1.6.0 release

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8799 )

Change subject: Updating web site for Kudu 1.6.0 release
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6718fb049880fe69464e73950166b5168859ab1
Gerrit-Change-Number: 8799
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 06:38:29 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) Updating web site for Kudu 1.6.0 release

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8799 )

Change subject: Updating web site for Kudu 1.6.0 release
..

Updating web site for Kudu 1.6.0 release

Change-Id: Ic6718fb049880fe69464e73950166b5168859ab1
Reviewed-on: http://gerrit.cloudera.org:8080/8799
Reviewed-by: Mike Percy 
Tested-by: Mike Percy 
---
M apidocs/allclasses-frame.html
M apidocs/allclasses-noframe.html
M apidocs/constant-values.html
M apidocs/deprecated-list.html
M apidocs/help-doc.html
M apidocs/index-all.html
M apidocs/index.html
A apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html
M apidocs/org/apache/kudu/ColumnSchema.html
M apidocs/org/apache/kudu/Schema.html
M apidocs/org/apache/kudu/Type.html
A apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html
M apidocs/org/apache/kudu/class-use/ColumnSchema.html
M apidocs/org/apache/kudu/class-use/Schema.html
M apidocs/org/apache/kudu/class-use/Type.html
M apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AlterTableOptions.html
M apidocs/org/apache/kudu/client/AlterTableResponse.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/CreateTableOptions.html
M apidocs/org/apache/kudu/client/Delete.html
M apidocs/org/apache/kudu/client/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/HasFailedRpcException.html
M apidocs/org/apache/kudu/client/Insert.html
M apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
A apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html
M apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
M apidocs/org/apache/kudu/client/KuduClient.html
M apidocs/org/apache/kudu/client/KuduException.html
M apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
M apidocs/org/apache/kudu/client/KuduPredicate.html
M apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
M apidocs/org/apache/kudu/client/KuduScanToken.html
M apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
M apidocs/org/apache/kudu/client/KuduScanner.html
M apidocs/org/apache/kudu/client/KuduSession.html
M apidocs/org/apache/kudu/client/KuduTable.html
M apidocs/org/apache/kudu/client/ListTablesResponse.html
M apidocs/org/apache/kudu/client/ListTabletServersResponse.html
M apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
M apidocs/org/apache/kudu/client/LocatedTablet.html
M apidocs/org/apache/kudu/client/Operation.html
M apidocs/org/apache/kudu/client/OperationResponse.html
M apidocs/org/apache/kudu/client/PartialRow.html
M apidocs/org/apache/kudu/client/PleaseThrottleException.html
M apidocs/org/apache/kudu/client/RangePartitionBound.html
M apidocs/org/apache/kudu/client/ReplicaSelection.html
M apidocs/org/apache/kudu/client/RowError.html
M apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
M apidocs/org/apache/kudu/client/RowResult.html
M apidocs/org/apache/kudu/client/RowResultIterator.html
M apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html
M apidocs/org/apache/kudu/client/SessionConfiguration.html
M apidocs/org/apache/kudu/client/Statistics.Statistic.html
M apidocs/org/apache/kudu/client/Statistics.html
M apidocs/org/apache/kudu/client/Status.html
M apidocs/org/apache/kudu/client/Update.html
M apidocs/org/apache/kudu/client/Upsert.html
M apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html
M apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html
M apidocs/org/apache/kudu/client/class-use/Delete.html
M apidocs/org/apache/kudu/client/class-use/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/class-use/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/class-use/HasFailedRpcException.html
M 

[kudu-CR](gh-pages) Make it possible to automate the docs release

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8798 )

Change subject: Make it possible to automate the docs release
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8049635640809ec6ec04fb482803e1439e3f2e
Gerrit-Change-Number: 8798
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 06:37:05 +
Gerrit-HasComments: No

[kudu-CR](gh-pages) Make it possible to automate the docs release

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8798 )

Change subject: Make it possible to automate the docs release
..

Make it possible to automate the docs release

Change-Id: Iad8049635640809ec6ec04fb482803e1439e3f2e
Reviewed-on: http://gerrit.cloudera.org:8080/8798
Reviewed-by: Mike Percy 
Tested-by: Mike Percy 
---
M releases/index.md
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/8798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad8049635640809ec6ec04fb482803e1439e3f2e
Gerrit-Change-Number: 8798
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] docs: Add scripts to automate web site update for releases

[Mike Percy (Code Review)]

Mike Percy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8800


Change subject: docs: Add scripts to automate web site update for releases
..

docs: Add scripts to automate web site update for releases

These scripts improve the web site deployment process for releases by
automatically placing the generated documentation in the correct
locations, updating the pointers to the new release, and creating a git
commit for all of the above.

Updated release management documentation to follow.

Change-Id: If55437e0561f0bf8e5e0ec0ae6e5bfca0311fb7d
---
A docs/support/scripts/prepare_release_docs.sh
A docs/support/scripts/release_index.md.template
A docs/support/scripts/update_release_list.pl
3 files changed, 181 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/8800/1
--
To view, visit http://gerrit.cloudera.org:8080/8800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If55437e0561f0bf8e5e0ec0ae6e5bfca0311fb7d
Gerrit-Change-Number: 8800
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 

[kudu-CR](gh-pages) Make it possible to automate the docs release

[Mike Percy (Code Review)]

Mike Percy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8798


Change subject: Make it possible to automate the docs release
..

Make it possible to automate the docs release

Change-Id: Iad8049635640809ec6ec04fb482803e1439e3f2e
---
M releases/index.md
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/8798/1
--
To view, visit http://gerrit.cloudera.org:8080/8798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad8049635640809ec6ec04fb482803e1439e3f2e
Gerrit-Change-Number: 8798
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 

[kudu-CR](gh-pages) Updating web site for Kudu 1.6.0 release

[Mike Percy (Code Review)]

Mike Percy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8799


Change subject: Updating web site for Kudu 1.6.0 release
..

Updating web site for Kudu 1.6.0 release

Change-Id: Ic6718fb049880fe69464e73950166b5168859ab1
---
M apidocs/allclasses-frame.html
M apidocs/allclasses-noframe.html
M apidocs/constant-values.html
M apidocs/deprecated-list.html
M apidocs/help-doc.html
M apidocs/index-all.html
M apidocs/index.html
A apidocs/org/apache/kudu/ColumnSchema.ColumnSchemaBuilder.html
M apidocs/org/apache/kudu/ColumnSchema.html
M apidocs/org/apache/kudu/Schema.html
M apidocs/org/apache/kudu/Type.html
A apidocs/org/apache/kudu/class-use/ColumnSchema.ColumnSchemaBuilder.html
M apidocs/org/apache/kudu/class-use/ColumnSchema.html
M apidocs/org/apache/kudu/class-use/Schema.html
M apidocs/org/apache/kudu/class-use/Type.html
M apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AlterTableOptions.html
M apidocs/org/apache/kudu/client/AlterTableResponse.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/CreateTableOptions.html
M apidocs/org/apache/kudu/client/Delete.html
M apidocs/org/apache/kudu/client/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/HasFailedRpcException.html
M apidocs/org/apache/kudu/client/Insert.html
M apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
A apidocs/org/apache/kudu/client/IsCreateTableDoneResponse.html
M apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
M apidocs/org/apache/kudu/client/KuduClient.html
M apidocs/org/apache/kudu/client/KuduException.html
M apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
M apidocs/org/apache/kudu/client/KuduPredicate.html
M apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
M apidocs/org/apache/kudu/client/KuduScanToken.html
M apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
M apidocs/org/apache/kudu/client/KuduScanner.html
M apidocs/org/apache/kudu/client/KuduSession.html
M apidocs/org/apache/kudu/client/KuduTable.html
M apidocs/org/apache/kudu/client/ListTablesResponse.html
M apidocs/org/apache/kudu/client/ListTabletServersResponse.html
M apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
M apidocs/org/apache/kudu/client/LocatedTablet.html
M apidocs/org/apache/kudu/client/Operation.html
M apidocs/org/apache/kudu/client/OperationResponse.html
M apidocs/org/apache/kudu/client/PartialRow.html
M apidocs/org/apache/kudu/client/PleaseThrottleException.html
M apidocs/org/apache/kudu/client/RangePartitionBound.html
M apidocs/org/apache/kudu/client/ReplicaSelection.html
M apidocs/org/apache/kudu/client/RowError.html
M apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
M apidocs/org/apache/kudu/client/RowResult.html
M apidocs/org/apache/kudu/client/RowResultIterator.html
M apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html
M apidocs/org/apache/kudu/client/SessionConfiguration.html
M apidocs/org/apache/kudu/client/Statistics.Statistic.html
M apidocs/org/apache/kudu/client/Statistics.html
M apidocs/org/apache/kudu/client/Status.html
M apidocs/org/apache/kudu/client/Update.html
M apidocs/org/apache/kudu/client/Upsert.html
M apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html
M apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html
M apidocs/org/apache/kudu/client/class-use/Delete.html
M apidocs/org/apache/kudu/client/class-use/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/class-use/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/class-use/HasFailedRpcException.html
M apidocs/org/apache/kudu/client/class-use/Insert.html
M apidocs/org/apache/kudu/client/class-use/IsAlterTableDoneResponse.html
A 

[kudu-CR] KUDU-1097: more robust criteria for replica eviction

[Alexey Serbin (Code Review)]

Hello Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8679

to look at the new patch set (#6).

Change subject: KUDU-1097: more robust criteria for replica eviction
..

KUDU-1097: more robust criteria for replica eviction

Updated the replica eviction criteria to address scenarios where newly
added replicas fail (before or after promotion) one after another
prior to eviction of the original failed voter replica.  With this
patch, the replacement process should not end up with placing failed
replicas at every available tablet server, deadlocking the replacement
process.  Added corresponding unit tests to cover the updated behavior
of the consensus::CanEvictReplica() utility function.

Updated the replica eviction criteria for more robust handling of the
'replace' attribute.  In this context, the case when the leader replica
itself is marked with the 'replace' attribute is now handled properly.
Added unit tests to cover appropriate cases.

Also, enabled the AdminCliTest.TestMoveTablet_KUDU_1097 test scenario
since now it should not be flaky anymore.

Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 709 insertions(+), 91 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8679/6
--
To view, visit http://gerrit.cloudera.org:8080/8679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
Gerrit-Change-Number: 8679
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-1097: more robust behavior for 'replica move'

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8786 
)

Change subject: KUDU-1097: more robust behavior for 'replica move'
..


Abandoned

It's a part of https://gerrit.cloudera.org/#/c/8679/ now
--
To view, visit http://gerrit.cloudera.org:8080/8786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I64988d9317c1610bc5ae2c7df5487b2427fdc183
Gerrit-Change-Number: 8786
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [quorum util] update criteria for voter replica eviction

[Alexey Serbin (Code Review)]

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8776 
)

Change subject: [quorum_util] update criteria for voter replica eviction
..


Abandoned

Now this is a part of: https://gerrit.cloudera.org/#/c/8679/
--
To view, visit http://gerrit.cloudera.org:8080/8776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibccc6e48554f7d62d4c70d092c8e992219129330
Gerrit-Change-Number: 8776
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-1097: more robust criteria for replica eviction

[Alexey Serbin (Code Review)]

Hello Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8679

to look at the new patch set (#5).

Change subject: KUDU-1097: more robust criteria for replica eviction
..

KUDU-1097: more robust criteria for replica eviction

Updated the replica eviction criteria to address scenarios where newly
added replicas fail (before or after promotion) one after another
prior to eviction of the original failed voter replica.  With this
patch, the replacement process should not end up with placing failed
replicas at every available tablet server, deadlocking the replacement
process.  Added corresponding unit tests to cover the updated behavior
of the consensus::CanEvictReplica() utility function.

Updated the replica eviction criteria for more robust handling of the
'replace' attribute.  In this context, the case when the leader replica
itself is marked with the 'replace' attribute is now handled properly.
Added unit tests to cover appropriate cases.

Also, enabled the AdminCliTest.TestMoveTablet_KUDU_1097 test scenario
since now it should not be flaky anymore.

Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 709 insertions(+), 91 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8679/5
--
To view, visit http://gerrit.cloudera.org:8080/8679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
Gerrit-Change-Number: 8679
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR](branch-1.6.x) docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8797 )

Change subject: docs: updates to data dir behavior
..

docs: updates to data dir behavior

Kudu tservers are now able to survive select disk failures, as well as
start up with new data dirs.

For a rendered version, see:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#change_dir_config

Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Reviewed-on: http://gerrit.cloudera.org:8080/8778
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
(cherry picked from commit add943f025347823f7f7f34de292efc2664961bb)
Reviewed-on: http://gerrit.cloudera.org:8080/8797
Tested-by: Mike Percy 
---
M docs/administration.adoc
1 file changed, 112 insertions(+), 28 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/8797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8797
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR](branch-1.6.x) kudu-hive: skip publishing artifact

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8794 )

Change subject: kudu-hive: skip publishing artifact
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Gerrit-Change-Number: 8794
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:50:25 +
Gerrit-HasComments: No

[kudu-CR](branch-1.6.x) kudu-hive: skip publishing artifact

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8794 )

Change subject: kudu-hive: skip publishing artifact
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Gerrit-Change-Number: 8794
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:50:03 +
Gerrit-HasComments: No

[kudu-CR](branch-1.6.x) docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8797


Change subject: docs: updates to data dir behavior
..

docs: updates to data dir behavior

Kudu tservers are now able to survive select disk failures, as well as
start up with new data dirs.

For a rendered version, see:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#change_dir_config

Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Reviewed-on: http://gerrit.cloudera.org:8080/8778
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
(cherry picked from commit add943f025347823f7f7f34de292efc2664961bb)
---
M docs/administration.adoc
1 file changed, 112 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/8797/1
--
To view, visit http://gerrit.cloudera.org:8080/8797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8797
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 

[kudu-CR](branch-1.6.x) kudu-hive: skip publishing artifact

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8794 )

Change subject: kudu-hive: skip publishing artifact
..

kudu-hive: skip publishing artifact

kudu-hive is experimental, so we should avoid publishing jars which
people could begin to rely on.

Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Reviewed-on: http://gerrit.cloudera.org:8080/8756
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit 84d019e611abc643e9138d6d0f9726a131643367)
Reviewed-on: http://gerrit.cloudera.org:8080/8794
Reviewed-by: Jean-Daniel Cryans 
---
M java/kudu-hive/pom.xml
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Jean-Daniel Cryans: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Gerrit-Change-Number: 8794
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR](branch-1.6.x) docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8797 )

Change subject: docs: updates to data dir behavior
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8797
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:49:49 +
Gerrit-HasComments: No

[kudu-CR](branch-1.6.x) java: re-revisit maven shade configuration

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8793 )

Change subject: java: re-revisit maven shade configuration
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8793
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:48:57 +
Gerrit-HasComments: No

[kudu-CR] docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..

docs: updates to data dir behavior

Kudu tservers are now able to survive select disk failures, as well as
start up with new data dirs.

For a rendered version, see:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#change_dir_config

Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Reviewed-on: http://gerrit.cloudera.org:8080/8778
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
---
M docs/administration.adoc
1 file changed, 112 insertions(+), 28 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mike Percy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR](branch-1.6.x) java: re-revisit maven shade configuration

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8793 )

Change subject: java: re-revisit maven shade configuration
..

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Reviewed-on: http://gerrit.cloudera.org:8080/8792
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Kudu Jenkins
(cherry picked from commit 6549a417b69747d1ef8472568e32026e0d96e464)
Reviewed-on: http://gerrit.cloudera.org:8080/8793
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Jean-Daniel Cryans: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8793
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 08 Dec 2017 03:39:39 +
Gerrit-HasComments: No

[kudu-CR] [quorum util] update criteria for non-voter replica eviction

[Alexey Serbin (Code Review)]

Hello Tidy Bot, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8679

to look at the new patch set (#4).

Change subject: [quorum_util] update criteria for non-voter replica eviction
..

[quorum_util] update criteria for non-voter replica eviction

Updated the non-voter replica eviction criteria to address a scenario
where newly added non-voter replicas fail one after another before the
original failed voter replica is evicted.  This is to make sure the
replacement process does not end up with placing failed non-voter
replicas at every available tablet server, deadlocking the replacement
process.

Added corresponding unit tests to cover the updated behavior of the
consensus::CanEvictReplica() utility function.

Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
---
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
3 files changed, 263 insertions(+), 76 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8679/4
--
To view, visit http://gerrit.cloudera.org:8080/8679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f
Gerrit-Change-Number: 8679
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [quorum util] update criteria for non-voter replica eviction

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8679 )

Change subject: [quorum_util] update criteria for non-voter replica eviction
..


Patch Set 3:

(17 comments)

http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:

http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@64
PS3, Line 64: FAIL
> LOG(FATAL) so we don't have to put NO_FATALS() around the SetOverallHealth(
It's a test, so FAIL() is enough here.  And no need to put NO_FATALS() all over 
the place neither.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@100
PS3, Line 100:   auto* peers = config->mutable_peers();
 :   bool found_peer = false;
 :   for (auto& peer : *peers) {
 : if (peer.permanent_uuid() == peer_uuid) {
 :   found_peer = true;
 :   peer.set_member_type(V);
 :   //peer.mutable_attrs()->clear_promote();
 :   peer.mutable_attrs()->set_promote(false);
 :   break;
 : }
 :   }
 :   if (!found_peer) {
 : FAIL() << peer_uuid << ": peer is not in the config";
 :   }
> we can write this in fewer lines using GetRaftConfigMember():
Good point, but I don't want to use ASSERT_OK() here: if the specified peer is 
not in the config, that's a programming error.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@116
PS3, Line 116: static void RemovePeer(RaftConfigPB* config, const string& 
peer_uuid) {
> we can just use bool RemoveFromRaftConfig(RaftConfigPB* config, const strin
Done


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@135
PS3, Line 135: if (!s.ok()) {
 : FAIL()
> why not just ASSERT_OK() ?
Because I don't think it's worth adding NO_FATALS() around every invocation of 
SetPeerHealth(): if the specified peer is not the part of the config, that must 
be programming error.  Also, I don't want to use CHECK() here because I want 
the test to perform proper clean-up and there is no use of crashdump in that 
case.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@530
PS3, Line 530:   for (char replace_health : kHealthStatuses) {
> this test has nothing to do with non-voters, right?
Right: as other sub-scenarios, it works with voter replicas.  I just used 
consolidated the testcases below, removing trying to remove some duplicated 
code.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@609
PS3, Line 609: .
> if we have enough healthy voters to commit the config change.
Done


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@661
PS3, Line 661: ASSERT_TRUE
> This one confuses me. Shouldn't this be ASSERT_FALSE because we don't have
This has changed once the criteria for the eviction updated.  See 
https://gerrit.cloudera.org/#/c/8786/


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@727
PS3, Line 727: SetPeerHealth
> nit: NO_FATALS() here and below
I use FAIL() in the implementation of SetPeerHealth() specifically for the 
purpose of not adding NO_FATALS() all over the place.  If SetPeerHealth() 
fails, that's a programming error.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@731
PS3, Line 731: Adding a non-voter for replacement
> nit: This comment could be a little clearer written as: Add a non-voter to
Done


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@742
PS3, Line 742: PromotePeer
> nit: NO_FATALS() here and below
The same story as for SetPeerHealth().


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@753
PS3, Line 753:   SetPeerHealth(, "D", '-');
> should we also test the (D, '?') case before it goes fully FAILED?
OK, we can do that.  But that's not how it's going to be in current 
implementation for replica health monitoring: it goes from '+' to '-' in the 
case of a crash, right?


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@754
PS3, Line 754:   ASSERT_FALSE(CanEvictReplica(config, "A", kReplicationFactor));
> nit: add comment: // We cannot evict because we don't have enough healthy v
Done


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@757
PS3, Line 757:   EXPECT_FALSE(CanEvictReplica(config, "A", kReplicationFactor));
 :   EXPECT_TRUE(IsUnderReplicated(config, kReplicationFactor));
> this duplicates the assertions above
Good catch -- that's left from the conflict resolution.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@775
PS3, Line 775:   // The processs 

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[Dan Burkert (Code Review)]

Hello Tidy Bot, Kudu Jenkins, Sailesh Mukil,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8692

to look at the new patch set (#3).

Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client
..

KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

The bulk of this commit is adding a new Thrift transport type,
SaslClientTransport, which facilitates SASL GSSAPI negotiation, as well
as integrity/privacy channel protection. The new transport is based on
Impala's version with some significant changes:

- Impala has a client and server SASL transport, necessitating a common
  superclass (SaslTransport). Since we only need a client transport, I
  collapsed all of the logic into a single class, which I think makes the
  code easier to follow.
- The transport uses Kudu helper types where possible, e.g., faststring
  buffers, and our existing SASL utility infrastructure.
- Integrity and privacy channel protection are implemented.

There are no standlone unit-tests for the transport, since that would
require implementing the server-specific counterpart. Instead, the class
is tested indirectly through using the HMS client to communicate with a
Kerberos-enabled HMS instance.

Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/hms/mini_hms.cc
M src/kudu/hms/mini_hms.h
A src/kudu/hms/sasl_client_transport.cc
A src/kudu/hms/sasl_client_transport.h
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/rpc/server_negotiation.cc
14 files changed, 859 insertions(+), 74 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8692/3
--
To view, visit http://gerrit.cloudera.org:8080/8692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345
Gerrit-Change-Number: 8692
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] java: re-revisit maven shade configuration

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8792 )

Change subject: java: re-revisit maven shade configuration
..

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Reviewed-on: http://gerrit.cloudera.org:8080/8792
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Kudu Jenkins
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

[Dan Burkert (Code Review)]

Hello Michael Ho, Tidy Bot, Alexey Serbin, Kudu Jenkins, Sailesh Mukil,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8755

to look at the new patch set (#6).

Change subject: KUDU-2121: fix SASL PLAIN fallback with 
rpc-authentication=optional
..

KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

The original issue was filed for certain Java edge cases, however
Sailesh and David who are working with KRPC in Impala pointed out that
the C++ side never does SASL PLAIN fallback when the server has Kerberos
enabled. This commit fixes both clients to correctly fall back to SASL
PLAIN when the server is Kerberized and authentication is optional.

Detecting whether the client has Kerberos credentials requires
using the GSSAPI directly instead of the SASL api. As a result, we now
find GSSAPI while building. Since GSSAPI is a direct dependency of Cyrus
SASL, this shouldn't cause any issues or require updating installation
docs.

Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
---
M CMakeLists.txt
A cmake_modules/FindGSSAPI.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M src/kudu/integration-tests/security-faults-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
18 files changed, 333 insertions(+), 98 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/8755/6
--
To view, visit http://gerrit.cloudera.org:8080/8755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Gerrit-Change-Number: 8755
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot

[kudu-CR](branch-1.6.x) kudu-hive: skip publishing artifact

[Dan Burkert (Code Review)]

Dan Burkert has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8794


Change subject: kudu-hive: skip publishing artifact
..

kudu-hive: skip publishing artifact

kudu-hive is experimental, so we should avoid publishing jars which
people could begin to rely on.

Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Reviewed-on: http://gerrit.cloudera.org:8080/8756
Reviewed-by: Mike Percy 
Tested-by: Kudu Jenkins
(cherry picked from commit 84d019e611abc643e9138d6d0f9726a131643367)
---
M java/kudu-hive/pom.xml
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/8794/1
--
To view, visit http://gerrit.cloudera.org:8080/8794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3417f1c8b39e3ce501f4a785faeadac59dd84c4
Gerrit-Change-Number: 8794
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 

[kudu-CR](branch-1.6.x) java: re-revisit maven shade configuration

[Dan Burkert (Code Review)]

Dan Burkert has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8793


Change subject: java: re-revisit maven shade configuration
..

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Reviewed-on: http://gerrit.cloudera.org:8080/8792
Reviewed-by: Jean-Daniel Cryans 
Tested-by: Kudu Jenkins
(cherry picked from commit 6549a417b69747d1ef8472568e32026e0d96e464)
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/8793/1
--
To view, visit http://gerrit.cloudera.org:8080/8793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8793
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8778

to look at the new patch set (#5).

Change subject: docs: updates to data dir behavior
..

docs: updates to data dir behavior

Kudu tservers are now able to survive select disk failures, as well as
start up with new data dirs.

For a rendered version, see:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#change_dir_config

Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
---
M docs/administration.adoc
1 file changed, 112 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/8778/5
--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8778/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8778/4/docs/administration.adoc@779
PS4, Line 779:  directory,
> directory
Done



--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 08 Dec 2017 00:28:44 +
Gerrit-HasComments: Yes

[kudu-CR] Add initial internal INT128/ int128 support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8533 )

Change subject: Add initial internal INT128/__int128 support
..


Patch Set 17:

(1 comment)

Nice, these literals are way-cool.

http://gerrit.cloudera.org:8080/#/c/8533/17/src/kudu/util/int128.h
File src/kudu/util/int128.h:

http://gerrit.cloudera.org:8080/#/c/8533/17/src/kudu/util/int128.h@57
PS17, Line 57: VALUE * 10 <= UINT128_MAX - CharValue(C)
could these first two clauses be simplified to one as

(VALUE <= (UINT128_MAX - CharValue(C)) / 10)

I know there are subtle overflow/rounding things going on here, so not entirely 
sure.



--
To view, visit http://gerrit.cloudera.org:8080/8533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1
Gerrit-Change-Number: 8533
Gerrit-PatchSet: 17
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 08 Dec 2017 00:27:32 +
Gerrit-HasComments: Yes

[kudu-CR] docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 4: Code-Review+1

(1 comment)

just one moretypo nit

http://gerrit.cloudera.org:8080/#/c/8778/4/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8778/4/docs/administration.adoc@779
PS4, Line 779: directories
directory



--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 08 Dec 2017 00:26:28 +
Gerrit-HasComments: Yes

[kudu-CR] java: re-revisit maven shade configuration

[Dan Burkert (Code Review)]

Hello Jean-Daniel Cryans, Grant Henke,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/8792

to review the following change.


Change subject: java: re-revisit maven shade configuration
..

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8792/1
--
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 

[kudu-CR] java: re-revisit maven shade configuration

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8792 )

Change subject: java: re-revisit maven shade configuration
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 08 Dec 2017 00:00:58 +
Gerrit-HasComments: No

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 3:

(11 comments)

Yeah, I think the changes make sense.

Also going with failure-tolerant/failure-intolerant instead of "resilient".

http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@731
PS3, Line 731: the server must be emptied
> the wal and data directories on the server must be deleted
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@732
PS3, Line 732: .
> , destroying the local copy of the data for each tablet replica hosted on t
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@733
PS3, Line 733: .
> if the replication factor is at least 3 and all other tablet servers are on
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@738
PS3, Line 738: server
> this will work on masters too, right? might want to add a note that these a
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@747
PS3, Line 747: rm -rf /data/0/kudu-tserver-wal/* /data/1/kudu-tserver/* 
/data/2/kudu-tserver/*
> add comment:
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@755
PS3, Line 755: emptied
> deleted
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@756
PS3, Line 756: created with the appropriate permissions
> You didn't mention this. shouldn't this happen automatically? Perhaps we sh
Ah, good point. The directories are created automatically when they start up so 
this needn't be in the docs.


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@762
PS3, Line 762: All directories on Kudu masters and select directories (the WAL 
directory and
 : the metadata directory) of tablet servers are not resilient to 
disk failures.
> How about: As of Kudu 1.6.0, Kudu master servers are not resilient to any t
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@764
PS3, Line 764: these
> non-resilient
Done


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@769
PS3, Line 769: failures of the other directories
> maybe: a disk failure on one of the failure-resilient directories (?)
failure-tolerant?


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@769
PS3, Line 769: automatically
 : re-replicate tablets with data on the affected disk, and the 
affected server
 : will remain alive with the logs indicating the failure, for 
example:
 :
> automatically stop using the affected disk, shut down tablets with blocks o
Done



--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 07 Dec 2017 22:52:33 +
Gerrit-HasComments: Yes

[kudu-CR] [quorum util] update criteria for non-voter replica eviction

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8679 )

Change subject: [quorum_util] update criteria for non-voter replica eviction
..


Patch Set 3:

(17 comments)

http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:

http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@64
PS3, Line 64: FAIL
LOG(FATAL) so we don't have to put NO_FATALS() around the SetOverallHealth() 
calls


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@100
PS3, Line 100:   auto* peers = config->mutable_peers();
 :   bool found_peer = false;
 :   for (auto& peer : *peers) {
 : if (peer.permanent_uuid() == peer_uuid) {
 :   found_peer = true;
 :   peer.set_member_type(V);
 :   //peer.mutable_attrs()->clear_promote();
 :   peer.mutable_attrs()->set_promote(false);
 :   break;
 : }
 :   }
 :   if (!found_peer) {
 : FAIL() << peer_uuid << ": peer is not in the config";
 :   }
we can write this in fewer lines using GetRaftConfigMember():

  RaftPeerPB* peer;
  ASSERT_OK(GetRaftConfigMember(config->mutable_peers(), peer_uuid, peer));
  peer->set_member_type(V);
  peer->mutable_attrs()->set_promote(false);


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@116
PS3, Line 116: static void RemovePeer(RaftConfigPB* config, const string& 
peer_uuid) {
we can just use bool RemoveFromRaftConfig(RaftConfigPB* config, const string& 
uuid);


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@135
PS3, Line 135: if (!s.ok()) {
 : FAIL()
why not just ASSERT_OK() ?


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@530
PS3, Line 530:   for (char replace_health : kHealthStatuses) {
this test has nothing to do with non-voters, right?


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@609
PS3, Line 609: .
if we have enough healthy voters to commit the config change.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@661
PS3, Line 661: ASSERT_TRUE
This one confuses me. Shouldn't this be ASSERT_FALSE because we don't have 
enough healthy voters to commit the config change? we only have 1/2 healthy 
voters here, while MajoritySize(2) == 2.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@727
PS3, Line 727: SetPeerHealth
nit: NO_FATALS() here and below


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@731
PS3, Line 731: Adding a non-voter for replacement
nit: This comment could be a little clearer written as: Add a non-voter to 
replace B.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@742
PS3, Line 742: PromotePeer
nit: NO_FATALS() here and below


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@753
PS3, Line 753:   SetPeerHealth(, "D", '-');
should we also test the (D, '?') case before it goes fully FAILED?


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@754
PS3, Line 754:   ASSERT_FALSE(CanEvictReplica(config, "A", kReplicationFactor));
nit: add comment: // We cannot evict because we don't have enough healthy 
voters to commit an eviction config change.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@757
PS3, Line 757:   EXPECT_FALSE(CanEvictReplica(config, "A", kReplicationFactor));
 :   EXPECT_TRUE(IsUnderReplicated(config, kReplicationFactor));
this duplicates the assertions above


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@775
PS3, Line 775:   // The processs converges: 3 voter replicas, all are healthy.
nit: it's a little early to say this in this comment. This state would occur 
after this next operation at the end of the test.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util-test.cc@779
PS3, Line 779:   EXPECT_FALSE(IsUnderReplicated(config, kReplicationFactor));
perhaps also assert that we cannot evict any nodes here, either.


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util.cc
File src/kudu/consensus/quorum_util.cc:

http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util.cc@531
PS3, Line 531: not to evict
to not evict


http://gerrit.cloudera.org:8080/#/c/8679/3/src/kudu/consensus/quorum_util.cc@544
PS3, Line 544:   // * A voter replica may be evicted only if the number of 
voter replicas in
 :   //   good health without the REPLACE attribute is greater or 
equal to the
 :   //   specified 

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 07 Dec 2017 23:16:19 +
Gerrit-HasComments: No

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Andrew Wong has removed a vote on this change.

Change subject: docs: updates to data dir behavior
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8755 )

Change subject: KUDU-2121: fix SASL PLAIN fallback with 
rpc-authentication=optional
..


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-itest.cc
File src/kudu/integration-tests/security-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/integration-tests/security-itest.cc@a185
PS5, Line 185:
> nit: maybe, it's worth keeping this line of the description for this test?
woops, good call.


http://gerrit.cloudera.org:8080/#/c/8755/4/src/kudu/rpc/client_negotiation.cc
File src/kudu/rpc/client_negotiation.cc:

http://gerrit.cloudera.org:8080/#/c/8755/4/src/kudu/rpc/client_negotiation.cc@809
PS4, Line 809:gss_error_description(minor, 
GSS_C_MECH_CODE));
> warning: do not use 'else' after 'return' [readability-else-after-return]
Done


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc
File src/kudu/rpc/client_negotiation.cc:

http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@432
PS5, Line 432: ials are
> nit: Should this be "enabled", since GSSAPI is available but just not used?
I've tightened up this message to read 'Kerberos credentials are not 
available', which I think is the clearest way of expressing the error.  I also 
fixed up the other places where this error is created in order to make it more 
consistent across clients.


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@789
PS5, Line 789: OM_uint32 messa
> nit: maybe, move this under the 'do {} while()' scope below?
Done


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@790
PS5, Line 790:
> ditto
Done


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@829
PS5, Line 829:  nullptr);
> Are we leaking 'cred' if we return here?
I don't think so, since we aren't getting an msan memory leak about this, and 
we do have a test that triggers this early return.  That being said, I've 
reorganized the control flow here just in case there's some corner case not 
covered by our unit tests.  It's a bit less linear, but does now always call 
release.


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@834
PS5, Line 834: as to be
> nit: remaining_life ?
I want to keep it as 'lifetime', because that's what the param is named in the 
gss_inquire_cred declaration. I have added a comment sentence explaining it's 
meaning, though.



--
To view, visit http://gerrit.cloudera.org:8080/8755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Gerrit-Change-Number: 8755
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 19:51:45 +
Gerrit-HasComments: Yes

[kudu-CR] docs: updates to data dir behavior

[Andrew Wong (Code Review)]

Hello Will Berkeley, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8778

to look at the new patch set (#4).

Change subject: docs: updates to data dir behavior
..

docs: updates to data dir behavior

Kudu tservers are now able to survive select disk failures, as well as
start up with new data dirs.

For a rendered version, see:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#change_dir_config

Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
---
M docs/administration.adoc
1 file changed, 112 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/8778/4
--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8789 )

Change subject: KUDU-2228: Make Messenger options configurable
..


Patch Set 3:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.h@168
PS3, Line 168:   int64_t rpc_negotiation_timeout_ms_ = 3000;
Probably best to set these defaults in the constructor to keep things 
consistent.


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.cc
File src/kudu/rpc/messenger.cc:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/messenger.cc@74
PS3, Line 74: // Default of 65 seconds.
nit: no need to comment this (it's obvious from context).


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/negotiation.h
File src/kudu/rpc/negotiation.h:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/negotiation.h@33
PS3, Line 33: enum class TriStateFlag;
This doesn't appear to be used.

Edit: or is it necessary because RpcAuthentication and RpcEncryption are 
typedefs?


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/rpc-test-base.h@564
PS3, Line 564:   void StartTestServer(Sockaddr *server_addr, bool enable_ssl = 
false,
Wrap this like you did with 'CreateMessenger'


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/rpc-test-base.h@605
PS3, Line 605:   void DoStartTestServer(Sockaddr *server_addr, bool enable_ssl 
= false,
ditto


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/sasl_common.cc
File src/kudu/rpc/sasl_common.cc:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/rpc/sasl_common.cc@269
PS3, Line 269:   is_kerberos_enabled.Store(kerberos_enabled);
I think it may be cleaner to pass in the kerberos_enabled flag into the Once, 
and set it there.  That will make it threadsafe as just a normal (non-atomic) 
static.  Unfortunately it doesn't look like the Google flavor of once supports 
flags to the init function, but the standard library does, so you'd have to 
switch it to use that.


http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/server/server_base.cc@52
PS3, Line 52: // for RpcAuthentication, RpcEncryption
this comment isn't necessary, we have a tool that checks headers.



--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 22:02:56 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

[Dan Burkert (Code Review)]

Dan Burkert has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8755 )

Change subject: KUDU-2121: fix SASL PLAIN fallback with 
rpc-authentication=optional
..

KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

The original issue was filed for certain Java edge cases, however
Sailesh and David who are working with KRPC in Impala pointed out that
the C++ side never does SASL PLAIN fallback when the server has Kerberos
enabled. This commit fixes both clients to correctly fall back to SASL
PLAIN when the server is Kerberized and authentication is optional.

Detecting whether the client has Kerberos credentials requires
using the GSSAPI directly instead of the SASL api. As a result, we now
find GSSAPI while building. Since GSSAPI is a direct dependency of Cyrus
SASL, this shouldn't cause any issues or require updating installation
docs.

Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Reviewed-on: http://gerrit.cloudera.org:8080/8755
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M CMakeLists.txt
A cmake_modules/FindGSSAPI.cmake
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M src/kudu/integration-tests/security-faults-itest.cc
M src/kudu/integration-tests/security-itest.cc
M src/kudu/mini-cluster/external_mini_cluster-test.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
18 files changed, 333 insertions(+), 98 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/8755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Gerrit-Change-Number: 8755
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] docs: updates to data dir behavior

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8778 )

Change subject: docs: updates to data dir behavior
..


Patch Set 3:

(11 comments)

looks good. added a few suggestions / thoughts, lmk what you think

http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@731
PS3, Line 731: the server must be emptied
the wal and data directories on the server must be deleted


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@732
PS3, Line 732: .
, destroying the local copy of the data for each tablet replica hosted on the 
local server.


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@733
PS3, Line 733: .
if the replication factor is at least 3 and all other tablet servers are online 
and healthy


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@738
PS3, Line 738: server
this will work on masters too, right? might want to add a note that these are 
instructions for tablet servers but the process is similar for master servers 
as well


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@747
PS3, Line 747: rm -rf /data/0/kudu-tserver-wal/* /data/1/kudu-tserver/* 
/data/2/kudu-tserver/*
add comment:

  # Note: this will delete all of the data from the local tablet server


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@755
PS3, Line 755: emptied
deleted


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@756
PS3, Line 756: created with the appropriate permissions
You didn't mention this. shouldn't this happen automatically? Perhaps we should 
mention that it's automatic. How can they tell whether it worked?


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@762
PS3, Line 762: All directories on Kudu masters and select directories (the WAL 
directory and
 : the metadata directory) of tablet servers are not resilient to 
disk failures.
How about: As of Kudu 1.6.0, Kudu master servers are not resilient to any types 
of disk failures. Kudu tablet servers are only resilient to disk failures if 
they occur on a disk storing data blocks, so the failure of a disk where the 
write-ahead logs or tablet metadata are stored will still result in data loss 
of the entire tablet server.


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@764
PS3, Line 764: these
non-resilient


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@769
PS3, Line 769: failures of the other directories
maybe: a disk failure on one of the failure-resilient directories (?)


http://gerrit.cloudera.org:8080/#/c/8778/3/docs/administration.adoc@769
PS3, Line 769: automatically
 : re-replicate tablets with data on the affected disk, and the 
affected server
 : will remain alive with the logs indicating the failure, for 
example:
 :
automatically stop using the affected disk, shut down tablets with blocks on 
the affected disk, and re-replicate the affected tablets to other tablet 
servers. The affected server will remain alive and will print messages to the 
log indicating the disk failure, for example:



--
To view, visit http://gerrit.cloudera.org:8080/8778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cfef4aeaba92228d2e0a77c7596847a6a3137e3
Gerrit-Change-Number: 8778
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 07 Dec 2017 20:33:42 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8755 )

Change subject: KUDU-2121: fix SASL PLAIN fallback with 
rpc-authentication=optional
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Gerrit-Change-Number: 8755
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 20:33:20 +
Gerrit-HasComments: No

[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8671

to look at the new patch set (#2).

Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster
..

[cluster_itest_util] update WaitForReplicasReportedToMaster

Updated signature of the itest::WaitForReplicasReportedToMaster utility
function to make the tablet locations and has_leader output parameters
optional.  This benefits tests which are only interested in the total
count of tablet replicas regardless of their locations.

Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/kudu-admin-test.cc
5 files changed, 60 insertions(+), 105 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8671/2
--
To view, visit http://gerrit.cloudera.org:8080/8671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc
Gerrit-Change-Number: 8671
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8789 )

Change subject: KUDU-2228: Make Messenger options configurable
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/util/flags.h
File src/kudu/util/flags.h:

http://gerrit.cloudera.org:8080/#/c/8789/3/src/kudu/util/flags.h@85
PS3, Line 85: template 
: inline Status ParseTriState(const char* flag_name, const 
std::string& flag_value, T* tri_state) {
:   if (boost::iequals(flag_value, "required")) {
: *tri_state = T::REQUIRED;
:   } else if (boost::iequals(flag_value, "optional")) {
: *tri_state = T::OPTIONAL;
:   } else if (boost::iequals(flag_value, "disabled")) {
: *tri_state = T::DISABLED;
:   } else {
: return Status::InvalidArgument(strings::Substitute(
:   "$0 flag must be one of 'required', 'optional', or 
'disabled'",
:   flag_name));
:   }
:   return Status::OK();
: }
Is there any particular reason making this function template?  Why not to 
declare it as non-template and move the implementation into the .cc file?



--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 17:34:48 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8789 )

Change subject: KUDU-2228: Make Messenger options configurable
..


Patch Set 3:

The last failure looks like a flaky test in:
MultiThreadedHybridClockTabletTest/2.UpdateNoMergeCompaction


--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 15:53:30 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Sailesh Mukil (Code Review)]

Hello Michael Ho, Tidy Bot, Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8789

to look at the new patch set (#3).

Change subject: KUDU-2228: Make Messenger options configurable
..

KUDU-2228: Make Messenger options configurable

Currently, the RPC layer accesses many gflags directly to take
certain decisions, eg. whether to turn on encryption,
authentication, etc.

Since the RPC layer is to be used more like a library, these should
be configurable options that are passed to the Messenger
(which is the API endpoint for the application using the RPC layer),
instead of the RPC layer itself directly accessing these flags.

This patch converts the following flags to Messenger options and moves
the flag definitions to server_base.cc which is the "application" in
Kudu that uses the Messenger:

FLAGS_rpc_default_keepalive_time_ms
FLAGS_rpc_negotiation_timeout_ms
FLAGS_rpc_authentication
FLAGS_rpc_encryption
FLAGS_rpc_certificate_file
FLAGS_rpc_private_key_file
FLAGS_rpc_ca_certificate_file
FLAGS_rpc_private_key_password_cmd
FLAGS_keytab_file

Most of the remaining flags are test or benchmark related flags. There
may be a few more flags that can be moved out and converted to options,
but we can leave that as future work if we decide to move them.

Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/negotiation.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/security/init.cc
M src/kudu/security/init.h
A src/kudu/security/security_flags.h
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/server/server_base.cc
M src/kudu/util/flags.h
15 files changed, 443 insertions(+), 279 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/8789/3
--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8789 )

Change subject: KUDU-2228: Make Messenger options configurable
..


Patch Set 2:

(13 comments)

http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:

http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@434
PS1, Line 434:  const std::string& 
rpc_certificate_file = "",
> warning: the parameter 'rpc_certificate_file' is copied for each invocation
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@435
PS1, Line 435:  const std::string& 
rpc_private_key_file = "",
> warning: the parameter 'rpc_private_key_file' is copied for each invocation
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@436
PS1, Line 436:  const std::string& 
rpc_ca_certificate_file = "",
> warning: the parameter 'rpc_ca_certificate_file' is copied for each invocat
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@437
PS1, Line 437:  const std::string& 
rpc_private_key_password_cmd = "") {
> warning: the parameter 'rpc_private_key_password_cmd' is copied for each in
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@569
PS1, Line 569: DoStartTestServer(server_addr, 
enable_ssl, rpc_certificate_file,
> warning: parameter 'rpc_certificate_file' is passed by value and only copie
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@570
PS1, Line 570: rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_private_key_file' is passed by value and only copie
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@570
PS1, Line 570: rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_ca_certificate_file' is passed by value and only co
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@570
PS1, Line 570: rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_private_key_password_cmd' is passed by value and on
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@613
PS1, Line 613:   CreateMessenger("TestServer", 
n_server_reactor_threads_, enable_ssl, rpc_certificate_file,
> warning: parameter 'rpc_certificate_file' is passed by value and only copie
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@614
PS1, Line 614:   rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_private_key_file' is passed by value and only copie
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@614
PS1, Line 614:   rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_private_key_password_cmd' is passed by value and on
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/rpc/rpc-test-base.h@614
PS1, Line 614:   rpc_private_key_file, rpc_ca_certificate_file, 
rpc_private_key_password_cmd);
> warning: parameter 'rpc_ca_certificate_file' is passed by value and only co
Done


http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:

http://gerrit.cloudera.org:8080/#/c/8789/1/src/kudu/server/server_base.cc@228
PS1, Line 228: } // namespace
> warning: anonymous namespace not terminated with a closing comment [google-
Done



--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 14:34:46 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Sailesh Mukil (Code Review)]

Hello Michael Ho, Tidy Bot, Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8789

to look at the new patch set (#2).

Change subject: KUDU-2228: Make Messenger options configurable
..

KUDU-2228: Make Messenger options configurable

Currently, the RPC layer accesses many gflags directly to take
certain decisions, eg. whether to turn on encryption,
authentication, etc.

Since the RPC layer is to be used more like a library, these should
be configurable options that are passed to the Messenger
(which is the API endpoint for the application using the RPC layer),
instead of the RPC layer itself directly accessing these flags.

This patch converts the following flags to Messenger options and moves
the flag definitions to server_base.cc which is the "application" in
Kudu that uses the Messenger:

FLAGS_rpc_default_keepalive_time_ms
FLAGS_rpc_negotiation_timeout_ms
FLAGS_rpc_authentication
FLAGS_rpc_encryption
FLAGS_rpc_certificate_file
FLAGS_rpc_private_key_file
FLAGS_rpc_ca_certificate_file
FLAGS_rpc_private_key_password_cmd
FLAGS_keytab_file

Most of the remaining flags are test or benchmark related flags. There
may be a few more flags that can be moved out and converted to options,
but we can leave that as future work if we decide to move them.

Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/negotiation.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/security/init.cc
M src/kudu/security/init.h
A src/kudu/security/security_flags.h
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/server/server_base.cc
M src/kudu/util/flags.h
15 files changed, 443 insertions(+), 267 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/8789/2
--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 2
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tidy Bot

[kudu-CR] [rpc] WIP: Introduce configurable options to Messenger

[Sailesh Mukil (Code Review)]

Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/6520 
)

Change subject: [rpc] WIP: Introduce configurable options to Messenger
..


Abandoned

Re-did the patch here:
https://gerrit.cloudera.org/#/c/8789/
--
To view, visit http://gerrit.cloudera.org:8080/6520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3685f137770d46f7c6537a37f76a0a6f71a00b11
Gerrit-Change-Number: 6520
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2228: Make Messenger options configurable

[Sailesh Mukil (Code Review)]

Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8789


Change subject: KUDU-2228: Make Messenger options configurable
..

KUDU-2228: Make Messenger options configurable

Currently, the RPC layer accesses many gflags directly to take
certain decisions, eg. whether to turn on encryption,
authentication, etc.

Since the RPC layer is to be used more like a library, these should
be configurable options that are passed to the Messenger
(which is the API endpoint for the application using the RPC layer),
instead of the RPC layer itself directly accessing these flags.

This patch converts the following flags to Messenger options and moves
the flag definitions to server_base.cc which is the "application" in
Kudu that uses the Messenger:

FLAGS_rpc_default_keepalive_time_ms
FLAGS_rpc_negotiation_timeout_ms
FLAGS_rpc_authentication
FLAGS_rpc_encryption
FLAGS_rpc_certificate_file
FLAGS_rpc_private_key_file
FLAGS_rpc_ca_certificate_file
FLAGS_rpc_private_key_password_cmd
FLAGS_keytab_file

Most of the remaining flags are test or benchmark related flags. There
may be a few more flags that can be moved out and converted to options,
but we can leave that as future work if we decide to move them.

Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
---
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/negotiation.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/sasl_common.cc
M src/kudu/rpc/sasl_common.h
M src/kudu/security/init.cc
M src/kudu/security/init.h
A src/kudu/security/security_flags.h
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/server/server_base.cc
M src/kudu/util/flags.h
15 files changed, 442 insertions(+), 267 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/8789/1
--
To view, visit http://gerrit.cloudera.org:8080/8789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba
Gerrit-Change-Number: 8789
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 

[kudu-CR] KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional

[Sailesh Mukil (Code Review)]

Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8755 )

Change subject: KUDU-2121: fix SASL PLAIN fallback with 
rpc-authentication=optional
..


Patch Set 5:

(3 comments)

Sorry for the late review, got caught up in some other work.

LGTM for the most part, just a few comments.

http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc
File src/kudu/rpc/client_negotiation.cc:

http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@432
PS5, Line 432: available
nit: Should this be "enabled", since GSSAPI is available but just not used?


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@829
PS5, Line 829: RETURN_NOT_OK(check_gss_error(major, minor));
Are we leaking 'cred' if we return here?


http://gerrit.cloudera.org:8080/#/c/8755/5/src/kudu/rpc/client_negotiation.cc@834
PS5, Line 834: lifetime
nit: remaining_life ?



--
To view, visit http://gerrit.cloudera.org:8080/8755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276
Gerrit-Change-Number: 8755
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Thu, 07 Dec 2017 11:06:19 +
Gerrit-HasComments: Yes