Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8755 )
Change subject: KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional ...................................................................... KUDU-2121: fix SASL PLAIN fallback with rpc-authentication=optional The original issue was filed for certain Java edge cases, however Sailesh and David who are working with KRPC in Impala pointed out that the C++ side never does SASL PLAIN fallback when the server has Kerberos enabled. This commit fixes both clients to correctly fall back to SASL PLAIN when the server is Kerberized and authentication is optional. Detecting whether the client has Kerberos credentials requires using the GSSAPI directly instead of the SASL api. As a result, we now find GSSAPI while building. Since GSSAPI is a direct dependency of Cyrus SASL, this shouldn't cause any issues or require updating installation docs. Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276 Reviewed-on: http://gerrit.cloudera.org:8080/8755 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M CMakeLists.txt A cmake_modules/FindGSSAPI.cmake M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKuduCluster.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java M src/kudu/integration-tests/security-faults-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/client_negotiation.cc M src/kudu/rpc/client_negotiation.h M src/kudu/rpc/negotiation-test.cc M src/kudu/security/tls_handshake.cc M src/kudu/tools/tool.proto M src/kudu/tools/tool_action_test.cc 18 files changed, 333 insertions(+), 98 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f42f4b7a8ac767ccae439feb1dcd49080827276 Gerrit-Change-Number: 8755 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot
