[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 4: Verified+1 Test

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] [client] replace Equals() with operator==()

2021-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17558 Change subject: [client] replace Equals() with operator==() .. [client] replace Equals() with operator==() This patch replaces the

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 4: Code-Review+2 --

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17547 to look at the new patch set (#4). Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 3: (8 comments)

[kudu-CR] [rest] add rest implementation

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17555 to look at the new patch set (#3). Change subject: [rest] add rest implementation .. [rest] add rest

[kudu-CR] [rest] add rest implementation

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17555 to look at the new patch set (#2). Change subject: [rest] add rest implementation .. [rest] add rest

[kudu-CR] [rest] add oat++ framework to kudu

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17554 to look at the new patch set (#2). Change subject: [rest] add oat++ framework to kudu .. [rest] add

[kudu-CR] [rest] add rest to master servers

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17556 to look at the new patch set (#2). Change subject: [rest] add rest to master servers .. [rest] add

[kudu-CR] KUDU-3291: properly disambiguate between deltas of a row with the same timestamp

2021-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17547 ) Change subject: KUDU-3291: properly disambiguate between deltas of a row with the same timestamp .. Patch Set 3: Code-Review+1 (8

[kudu-CR] Add cmake modules to find oat++ Modify thirdparty scripts to include oat++ Modify kudu CMakeLists.txt to add oat++ and rest subdirectory

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17554 to review the following change. Change subject: Add cmake_modules to find oat++ Modify thirdparty scripts to include oat++ Modify kudu CMakeLists.txt to add oat++ and rest

[kudu-CR] Modify master to have a rest server as member Modify master to have a threadpool for rest Modify master constructor to include the rest server Modify master to add flags for controlling the

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17556 to review the following change. Change subject: Modify master to have a rest server as member Modify master to have a threadpool for rest Modify master constructor to include the rest

[kudu-CR] Add controller.h for rest endpoint mapping Add DTO, JSON objects of oat++ for rest Add RestServer to use in master

2021-06-07 Thread Khazar Mammadli (Code Review)
Hello Attila Bukor, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/17555 to review the following change. Change subject: Add controller.h for rest endpoint mapping Add DTO, JSON objects of oat++ for rest Add RestServer to use in master

[kudu-CR] A poc Oat++ Rest server

2021-06-07 Thread Khazar Mammadli (Code Review)
Khazar Mammadli has abandoned this change. ( http://gerrit.cloudera.org:8080/17410 ) Change subject: A poc Oat++ Rest server .. Abandoned Outdated, a more up-to-date patch will replace it -- To view, visit