[kudu-CR] move configuration constants into separate class and make public

2017-12-27 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8920 Change subject: move configuration constants into separate class and make public .. move configuration constants into separate class

[kudu-CR] Move configuration keys into its own class and make public

2018-01-11 Thread Clemens Valiente (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8920 to look at the new patch set (#2). Change subject: Move configuration keys into its own class and make public

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-05 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader .. Patch Set 4: All done, thanks for

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-05 Thread Clemens Valiente (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8921 to look at the new patch set (#4). Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

[kudu-CR] move configuration constants into separate class and make public

2018-01-05 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 ) Change subject: move configuration constants into separate class and make public .. Patch Set 1: Sorry, this is definitely my fault

[kudu-CR] KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

2018-01-04 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader .. Patch Set 2: > Patch Set 1: >

[kudu-CR] KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

2018-01-04 Thread Clemens Valiente (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8921 to look at the new patch set (#3). Change subject: KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

[kudu-CR] KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader class

2018-01-04 Thread Clemens Valiente (Code Review)
Clemens Valiente has abandoned this change. ( http://gerrit.cloudera.org:8080/8937 ) Change subject: KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader class .. Abandoned -- To

[kudu-CR] KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader

2018-01-04 Thread Clemens Valiente (Code Review)
Clemens Valiente has abandoned this change. ( http://gerrit.cloudera.org:8080/8938 ) Change subject: KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader .. Abandoned duplicate --

[kudu-CR] KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

2018-01-04 Thread Clemens Valiente (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8921 to look at the new patch set (#2). Change subject: KUDU-2249 Prevent race condition between getSplits() method and TableRecordReader

[kudu-CR] KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader class

2018-01-04 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8937 Change subject: KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader class .. KUDU-2249

[kudu-CR] KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader

2018-01-04 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8938 Change subject: KUDU-2249 Prevent a possible race conditions between the getSplits() method and TableRecordReader .. KUDU-2249

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-08 Thread Clemens Valiente (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8921 to look at the new patch set (#5). Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

[kudu-CR] KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader

2018-01-08 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 Avoid sharing the client between the InputFormat and RecordReader .. Patch Set 4: > Patch Set 4: > > (2

[kudu-CR] KUDU-2249 give the TableRecordReader their own KuduClient to use.

2017-12-28 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8921 Change subject: KUDU-2249 give the TableRecordReader their own KuduClient to use. .. KUDU-2249 give the TableRecordReader their own

[kudu-CR] KUDU-2249 give the TableRecordReader their own KuduClient to use.

2018-01-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8921 ) Change subject: KUDU-2249 give the TableRecordReader their own KuduClient to use. .. Patch Set 1: (1 comment) Hi David, I

[kudu-CR] Throw exception on write errors with the kudu-mapreduce client

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#2). Change subject: Throw exception on write errors with the kudu-mapreduce client

[kudu-CR] throw error on write errors

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13228 Change subject: throw error on write errors .. throw error on write errors Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7 ---

[kudu-CR] Throw exception on write errors with kudu-mapreduce

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#3). Change subject: Throw exception on write errors with kudu-mapreduce .. Throw

[kudu-CR] Throw exception on write error with kudu-mapreduce

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#4). Change subject: Throw exception on write error with kudu-mapreduce .. Throw

[kudu-CR] Throw exception on write error with kudu-mapreduce

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#5). Change subject: Throw exception on write error with kudu-mapreduce .. Throw

[kudu-CR] Throw exception on write error with kudu-mapreduce

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#6). Change subject: Throw exception on write error with kudu-mapreduce .. Throw

[kudu-CR] Throw exception on write error with kudu-mapreduce

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 ) Change subject: Throw exception on write error with kudu-mapreduce .. Patch Set 7: Yes, I had a look at it and it turns out

[kudu-CR] [HIVE-12971] add a hive serde for kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13230 Change subject: [HIVE-12971] add a hive serde for kudu .. [HIVE-12971] add a hive serde for kudu Change-Id:

[kudu-CR] HIVE-12971 Add a Hive serde for Kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has abandoned this change. ( http://gerrit.cloudera.org:8080/13228 ) Change subject: HIVE-12971 Add a Hive serde for Kudu .. Abandoned not fixing kudu-mapreduce further -- To view, visit

[kudu-CR] HIVE-12971 Add a Hive serde for Kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13231 Change subject: HIVE-12971 Add a Hive serde for Kudu .. HIVE-12971 Add a Hive serde for Kudu Change-Id:

[kudu-CR] HIVE-12971 Add a Hive serde for Kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Clemens Valiente has abandoned this change. ( http://gerrit.cloudera.org:8080/13231 ) Change subject: HIVE-12971 Add a Hive serde for Kudu .. Abandoned Duplicate, see https://gerrit.cloudera.org/#/c/13230/ -- To view, visit

[kudu-CR] HIVE-12971 Add a Hive serde for Kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13228 to look at the new patch set (#8). Change subject: HIVE-12971 Add a Hive serde for Kudu .. HIVE-12971

[kudu-CR] HIVE-12971 Add a Hive serde for Kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13231 to look at the new patch set (#2). Change subject: HIVE-12971 Add a Hive serde for Kudu .. HIVE-12971 Add a Hive

[kudu-CR] [HIVE-12971] add a hive serde for kudu

2019-05-03 Thread Clemens Valiente (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13230 to look at the new patch set (#2). Change subject: [HIVE-12971] add a hive serde for kudu .. [HIVE-12971] add a