[kudu-CR] KUDU-2750: Add create and alter timestamp to tables

2019-03-24 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12842 Change subject: KUDU-2750: Add create and alter timestamp to tables .. KUDU-2750: Add create and alter timestamp to tables Add create and

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#7). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 7: Yeah, i will rebase on master after this

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 6: (5 comments)

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#8). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#9). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12890 to look at the new patch set (#10). Change subject: java/c++: ColumnSchema supports storing column comment

[kudu-CR] java/c++: ColumnSchema supports storing column comment

2019-04-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java/c++: ColumnSchema supports storing column comment .. Patch Set 9: (2 comments)

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12891 to look at the new patch set (#2). Change subject: client: convert the has_foo booleans into boost::optional

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12891 ) Change subject: client: convert the has_foo booleans into boost::optional .. Patch Set 1: (6 comments)

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12891 to look at the new patch set (#3). Change subject: client: convert the has_foo booleans into boost::optional

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12891 ) Change subject: client: convert the has_foo booleans into boost::optional .. Patch Set 2: (2 comments)

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12891 to look at the new patch set (#4). Change subject: client: convert the has_foo booleans into boost::optional

[kudu-CR] java: ColumnSchema supports storing column comment

2019-03-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12890 ) Change subject: java: ColumnSchema supports storing column comment .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#8). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] client: convert the has foo booleans into boost::optional

2019-03-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12891 Change subject: client: convert the has_foo booleans into boost::optional .. client: convert the has_foo booleans into boost::optional this

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 9: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-28 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#9). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] java: ColumnSchema supports storing column comment

2019-03-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12890 Change subject: java: ColumnSchema supports storing column comment .. java: ColumnSchema supports storing column comment This patch intends

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#7). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12849 to look at the new patch set (#6). Change subject: KUDU-1711: ColumnSchema supports storing column comment

[kudu-CR] KUDU-1711: ColumnSchema supports storing column comment

2019-03-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12849 ) Change subject: KUDU-1711: ColumnSchema supports storing column comment .. Patch Set 3: (9 comments) yes, the impala catalog uses kudu java

[kudu-CR] KUDU-2653: suppress krb5 memory leak found on Debian 8

2019-02-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12558 ) Change subject: KUDU-2653: suppress krb5 memory leak found on Debian 8 .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-02-26 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12588 Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1: Introduce CRoaring Introduce CRoaring and do a simple memory and disk

[kudu-CR] KUDU-2653: suppress krb5 memory leak found on Debian 8

2019-02-24 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12558 ) Change subject: KUDU-2653: suppress krb5 memory leak found on Debian 8 .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-02-26 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12588 to look at the new patch set (#2). Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1: Introduce

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12701 to look at the new patch set (#6). Change subject: KUDU-2038-p2: support for index metadata management ..

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-11 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12701 to look at the new patch set (#3). Change subject: KUDU-2038-p2: support for index metadata management ..

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12701 to look at the new patch set (#4). Change subject: KUDU-2038-p2: support for index metadata management ..

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-08 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12701 Change subject: KUDU-2038-p2: support for index metadata management .. KUDU-2038-p2: support for index metadata management The purpose of

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-09 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12701 to look at the new patch set (#2). Change subject: KUDU-2038-p2: support for index metadata management ..

[kudu-CR] KUDU-2693. Buffer blocks while flushing rowsets

2019-03-19 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12425 ) Change subject: KUDU-2693. Buffer blocks while flushing rowsets .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-11 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12701 ) Change subject: KUDU-2038-p2: support for index metadata management .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2038-p2: support for index metadata management

2019-03-13 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12701 to look at the new patch set (#5). Change subject: KUDU-2038-p2: support for index metadata management ..

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-13 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (9 comments)

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-13 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#2). Change subject: Fix compilation warnings under debian8.9 .. Fix

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 2: "and the same to the other files" means:

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 2: (3 comments)

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#3). Change subject: Fix compilation warnings under debian8.9 .. Fix

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 3: (2 comments)

[kudu-CR] Fix compilation warnings under debian8.9

2019-02-14 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12294 to look at the new patch set (#4). Change subject: Fix compilation warnings under debian8.9 .. Fix

[kudu-CR] KUDU-2038: Support bitmap index

2019-02-20 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/11722 ) Change subject: KUDU-2038: Support bitmap index .. Patch Set 6: I am glad to receive your new reply about the secondary index here. Yea, the

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-23 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#6). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-24 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12239 ) Change subject: [fs]: delete the (orphaned) metadata file when repairing .. Patch Set 6: (5 comments)

[kudu-CR] [fs]: delete the (orphaned) metadata file when repairing

2019-01-24 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12239 to look at the new patch set (#7). Change subject: [fs]: delete the (orphaned) metadata file when repairing

[kudu-CR] KUDU2665: LBM deletes the valid live block

2019-01-30 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12308 Change subject: KUDU2665: LBM deletes the valid live block .. KUDU2665: LBM deletes the valid live block Due to the nature of WritableBlock

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM may delete containers with live blocks .. Patch Set 2: (5 comments)

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM may delete containers with live blocks .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2665: LBM may delete containers with live blocks

2019-01-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12308 to look at the new patch set (#3). Change subject: KUDU-2665: LBM may delete containers with live blocks

[kudu-CR] Fix compilation warnings under debian8.9

2019-01-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12294 ) Change subject: Fix compilation warnings under debian8.9 .. Patch Set 1: (9 comments)

[kudu-CR] KUDU-2665: LBM may delete containers with live blocks

2019-02-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU-2665: LBM may delete containers with live blocks .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2665: LBM may delete containers with live blocks

2019-02-01 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12308 to look at the new patch set (#4). Change subject: KUDU-2665: LBM may delete containers with live blocks

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12308 to look at the new patch set (#2). Change subject: KUDU2665: LBM may delete containers with live blocks

[kudu-CR] KUDU2665: LBM may delete containers with live blocks

2019-01-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM may delete containers with live blocks .. Patch Set 2: if we comment 'blocks_being_written() == 0' in the

[kudu-CR] KUDU2665: LBM deletes the valid live block

2019-01-30 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12308 ) Change subject: KUDU2665: LBM deletes the valid live block .. Patch Set 1: (6 comments)

[kudu-CR] Fix compilation warnings under debian8.9

2019-01-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12294 Change subject: Fix compilation warnings under debian8.9 .. Fix compilation warnings under debian8.9 It seems there are some compilation

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-16 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Patch Set 1: Code-Review+1 (1 comment) Glad to see this

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13064 Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1: Introduce CRoaring Introduce CRoaring and do a simple memory and disk

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12588 to look at the new patch set (#4). Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1:

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
helifu has abandoned this change. ( http://gerrit.cloudera.org:8080/13064 ) Change subject: KUDU-2038-p1: Introduce CRoaring .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13064 To unsubscribe, visit

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12588 to look at the new patch set (#5). Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1:

[kudu-CR] [KUDU-2825]add a column named role in 'kudu master list' add a column name role in 'kudu master list' to show the role of each master?roles include master,follower,learner, nonparticipant an

2019-05-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13435 ) Change subject: [KUDU-2825]add a column named role in 'kudu master list' add a column name role in 'kudu master list' to show the role of each master?roles include master,follower,learner, nonparticipant and

[kudu-CR] [KUDU-2825]add a column named role in 'kudu master list' add a column name role in 'kudu master list' to show the role of each master?roles include master,follower,learner, nonparticipant an

2019-05-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13435 ) Change subject: [KUDU-2825]add a column named role in 'kudu master list' add a column name role in 'kudu master list' to show the role of each master?roles include master,follower,learner, nonparticipant and

[kudu-CR] [util] Support for entity type/id/attrs/metrics filtering in metrics

2019-05-25 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13376 ) Change subject: [util] Support for entity type/id/attrs/metrics filtering in metrics .. Patch Set 6: (4 comments)

[kudu-CR] [util] Support for entity type/id/attrs/metrics filtering in metrics

2019-05-25 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13376 to look at the new patch set (#7). Change subject: [util] Support for entity type/id/attrs/metrics filtering in metrics

[kudu-CR] [util] Support for entity types/ids/attrs/metrics filtering in metrics

2019-05-25 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13376 to look at the new patch set (#8). Change subject: [util] Support for entity types/ids/attrs/metrics filtering in metrics

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-05-26 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 1: (9 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (2 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (4 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#7). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#12). Change subject: [tablet] Support accurate count of rows

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: (8 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#13). Change subject: [tablet] Support accurate count of rows

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-05 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#2). Change subject: KUDU-2797: the master aggregates tablet metrics

[kudu-CR] [tablet] Support accurate count of rows

2019-05-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#4). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 4: (19 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-05-31 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#5). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 2: (3 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13456 Change subject: [tablet] Support accurate count of rows .. [tablet] Support accurate count of rows For the MemRowSet and DeltaMemStore, there

[kudu-CR] [tablet] Support accurate count of rows

2019-05-30 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#3). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#2). Change subject: [tablet] Support accurate count of rows .. [tablet] Support

[kudu-CR] [tablet] Support accurate count of rows

2019-05-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 1: (1 comment)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-01 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#6). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 7: (16 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#8). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#10). Change subject: [tablet] Support accurate count of rows ..

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 9: (4 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#9). Change subject: [tablet] Support accurate count of rows .. [tablet]

[kudu-CR] [tablet] Support accurate count of rows

2019-06-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 10: (2 comments)

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#11). Change subject: [tablet] Support accurate count of rows ..

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-06 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#3). Change subject: KUDU-2797: the master aggregates tablet metrics

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#14). Change subject: [tablet] Support accurate count of rows

[kudu-CR] [tablet] Support accurate count of rows

2019-06-05 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 13: (2 comments)

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-06 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#4). Change subject: KUDU-2797: the master aggregates tablet metrics

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-05-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2797: the master aggregates tablet metrics

2019-06-12 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 ) Change subject: KUDU-2797: the master aggregates tablet metrics .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2797: the master aggregates tablet statistics

2019-06-12 Thread helifu (Code Review)
Hello Mike Percy, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13426 to look at the new patch set (#7). Change subject: KUDU-2797: the master aggregates tablet statistics

<    1   2   3   4   >